CFM-274_breadcrumb_improvements_fixes #338
Conversation
Ioannis
force-pushed
the
CFM-274_breadcrumb_improvements_fixes
branch
2 times, most recently
from
45e0458
to
596ff76
Compare
Ioannis
force-pushed
the
CFM-274_breadcrumb_improvements_fixes
branch
from
596ff76
to
131c8d6
Compare
| @@ -49,20 +49,21 @@ | |||
|
|
|||
| namespace App\Controller\Component; | |||
|
|
|||
| use App\Model\Entity; | |||
There was a problem hiding this comment.
Is there a reason this one line is relative instead of absolute?
There was a problem hiding this comment.
Actually this import is redundant. I will remove it.
| public static function pluginToTextDomain(?string $plugin): string | ||
| { | ||
| if (empty($plugin)) { | ||
| return 'operation'; | ||
| } | ||
| return \Cake\Utility\Inflector::singularize(\Cake\Utility\Inflector::tableize($plugin)); | ||
| } |
There was a problem hiding this comment.
Note FieldHelper::calculateLabelAndDescription does something similar, but just uses Inflector::underscore. It's actually not clear to me that singularize is correct here. While by convention our plugins are named singularly, I don't see a requirement for that, and the documentation simply says "plugins should use the underscored version of their name as the domain for translation." (which is consistent with FieldHelper's logic).
FieldHelper should probably be updated to use this new call.
There was a problem hiding this comment.
Fixed. I will use the StringUtility method in the FieldHelper for consistency.
No description provided.