[NO JIRA] Bug fixes #346
Merged
[NO JIRA] Bug fixes #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ioannis
changed the title
benno
reviewed
Oct 28, 2025
Comment on lines
36
to
37
| $app->addPlugin(\CakeDC\OracleDriver\Plugin::class, ['bootstrap' => true]); | ||
| $app->addPlugin(\Ioigoume\OracleDriver\Plugin::class, ['bootstrap' => true]); | ||
| } |
There was a problem hiding this comment.
Is this right? (Also, below.)
There was a problem hiding this comment.
There was a problem hiding this comment.
Let's break the Oracle changes into a separate PR. I want to think a bit more about how to isolate the CoreServer code from random packages.
There was a problem hiding this comment.
@benno changes removed
benno
reviewed
Oct 28, 2025
| 'couIds' => [ | ||
| 'cous' => [ |
There was a problem hiding this comment.
What are autoViewVars even used for here? The view view is completely custom...
There was a problem hiding this comment.
The petition view knows the id of the cou but has no knowledge of the name. This way we can map the id to a name and render it to the view.
|
@benno can you please follow up. |
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.