CFM-496_REST_API_v2_DELETE_CO_Group_returns_400 #360
+31
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Ioannis
commented
Dec 18, 2025
•
Ioannis
commented
- Fix groups read-only delete.
- Improve error information for privileged users.
- Fix ApiUser Key title calculation bug.
… users. Fix api user key title caclulation bug.
benno
reviewed
Jan 3, 2026
Comment on lines
+249
to
+252
| $priv = $ApiUsers->getUserPrivilege($this->authenticatedUser); | ||
| $apiUserCoId = $this->cache['api_user']['co_id'] ?? null; | ||
|
|
||
| if ($priv === true || ($apiUserCoId !== null && $priv === $apiUserCoId)) { |
There was a problem hiding this comment.
It's not immediately obvious to me that a privileged API user should see error messages, especially on a multitenant instance where they may be trying to manipulate a record that isn't within their own CO.
Comment on lines
+255
to
+261
| // Align with REST API: do not allow delete of read-only records | ||
| if (method_exists($obj, "isReadOnly") && $obj->isReadOnly()) { | ||
| $this->Flash->error(__d('error', 'edit.readonly')); | ||
| // Redirect to view, as we do for read-only edits | ||
| return $this->redirect(['action' => 'view', $obj->id]); | ||
| } | ||
|
|
There was a problem hiding this comment.
How does one trigger the delete of a read only record? The UI shouldn't offer that option in the first place.
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.