Add EIS badges to Person Canvas (CFM-417) #364
+61
−1
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -90,6 +90,29 @@ public function beforeRender(\Cake\Event\EventInterface $event) { | |
| $this->set('vv_default_name_type', $settings->default_name_type_id); | ||
| } | ||
|
|
||
| if(!$this->request->is('restful') && $this->request->getParam('action') == 'edit') { | ||
| // Get the external identity sources for this person | ||
| $externalIdentitySources = $this->fetchTable('ExternalIdentities') | ||
| ->find() | ||
| ->where(['ExternalIdentities.person_id' => $this->request->getParam('pass.0')]) | ||
| ->contain([ | ||
| 'ExtIdentitySourceRecords' => [ | ||
| 'ExternalIdentitySources' | ||
| ] | ||
| ]) | ||
| ->all(); | ||
|
|
||
| // Create a lookup table for badging EIS descriptions on Person Canvas MVEAS | ||
| $eisLookupTable = []; | ||
| foreach ($externalIdentitySources as $extIdentity) { | ||
| if (!empty($extIdentity->ext_identity_source_record) && | ||
| !empty($extIdentity->ext_identity_source_record->external_identity_source)) { | ||
| $eisLookupTable[$extIdentity->id] = $extIdentity->ext_identity_source_record->external_identity_source->description; | ||
| } | ||
| } | ||
|
Comment on lines
+97
to
+112
There was a problem hiding this comment. I think your query will be simpler if you always pull all EIS for the CO, instead of walking from the Person to the EIS Records that the Person is associated with. ie: you're doing more work to get a more exact answer, but it's probably an over-optimization. Something like You can then use Cake's Hash utility to create your lookup table. I believe |
||
|
|
||
| $this->set('vv_external_identity_sources', $eisLookupTable); | ||
| } | ||
| return parent::beforeRender($event); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you look above we use
TableRegistryand then run the find on the table as a second action. This is a bit more general of a solution (less work in contexts where we run multiple actions on a table, more generic wherefetchTable()isn't a thing) though some older code does still usefetchTable(). Minimally, adjacent code shouldn't do the same thing two different ways.