Improve accessibility (CFM-491) #384
Open
+52
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benno
reviewed
Apr 6, 2026
Comment on lines
33
to
50
| msgid "aria.label.actions" | ||
| msgstr "Actions menu" | ||
|
|
||
| msgid "aria.label.lightbox" | ||
| msgstr "Registry lightbox" | ||
|
|
||
| msgid "aria.label.lightbox.main" | ||
| msgstr "Registry lightbox content" | ||
|
|
||
| msgid "aria.label.search" | ||
| msgstr "Search and user menu" | ||
|
|
||
| msgid "aria.label.subnavigation" | ||
| msgstr "Subnavigation" | ||
|
|
||
| msgid "aria.label.subnavigation.links" | ||
| msgstr "Subnavigation secondary links" | ||
|
|
There was a problem hiding this comment.
information.po doesn't quite feel right as the place to put the aria labels. My first thought was to add a new accessibility.po file, but that doesn't feel right either, especially when most accessibility translations should probably be closer to their context (eg: field.po:foo.alttext).
Some of these maybe go in menu.po?
There was a problem hiding this comment.
I've moved them into menu.po.
There was a problem hiding this comment.
...and rebased against the latest develop
arlen
force-pushed
the
feature-cfm491-accessibilityImprovements
branch
from
06180be to
85c332c
Compare
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves a number of accessibility issues, adding aria attributes where appropriate and ensuring that labels are present for all input fields.