CFM-555_Fix_TypeError_and_maximum_bound_handling_in_assignCollisionNumber #459
+36
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ignCollisionNumber
benno
reviewed
Oct 1, 2026
Comment on lines
-276
to
+289
| for($j = 0;$j < strlen($base);$j++) { | ||
| for($j = 0, $jMax = strlen($base); $j < $jMax; $j++) { |
Contributor
There was a problem hiding this comment.
How strongly do you feel about rewriting all these for loops?
Commentators in PHP documentation like to overoptimize performance, and calling strlen once per loop is a trivial rounding error in the overall cost of the page load. Personally I find the second line harder to read, but that's just opinion.
Sign in
to join this conversation on GitHub.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.