Merged in bugfix/SHIBUI-1387 (pull request #350)

SHIBUI-1387 Fixed issue with layout in summary Approved-by: Ryan Mathis <rmathis@unicon.net>
TIER · Aug 5, 2019 · 0a1240c · 0a1240c
2 parents b8207c7 + e85e91f
commit 0a1240c
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 7 deletions.
diff --git a/backend/src/main/resources/i18n/messages.properties b/backend/src/main/resources/i18n/messages.properties
@@ -166,10 +166,10 @@ label.x509-certificates=X509 Certificates
 label.certificate-name-display-only=Certificate Name (Display Only)
 label.certificate=Certificate
 label.assertion-consumer-services=Assertion Consumer Services
-label.assertion-consumer-service-location=Assertion Consumer Service Location
+label.assertion-consumer-service-location=Location
 label.assertion-consumer-service-endpoint=Assertion Consumer Service Endpoints
 label.default=(default)
-label.assertion-consumer-service-location-binding=Assertion Consumer Service Location Binding
+label.assertion-consumer-service-location-binding=Location Binding
 label.relying-party-overrides=Relying Party Overrides
 label.sign-the-assertion=Sign the Assertion?
 label.turn-off-encryption-of-response=Turn off Encryption of Response?

diff --git a/backend/src/main/resources/i18n/messages_en.properties b/backend/src/main/resources/i18n/messages_en.properties
@@ -159,10 +159,10 @@ label.x509-certificates=X509 Certificates
 label.certificate-name-display-only=Certificate Name (Display Only)
 label.certificate=Certificate
 label.assertion-consumer-services=Assertion Consumer Services
-label.assertion-consumer-service-location=Assertion Consumer Service Location
+label.assertion-consumer-service-location=Location
 label.assertion-consumer-service-endpoint=Assertion Consumer Service Endpoints
 label.default=(default)
-label.assertion-consumer-service-location-binding=Assertion Consumer Service Location Binding
+label.assertion-consumer-service-location-binding=Location Binding
 label.relying-party-overrides=Relying Party Overrides
 label.sign-the-assertion=Sign the Assertion?
 label.turn-off-encryption-of-response=Turn off Encryption of Response?

diff --git a/ui/src/app/metadata/domain/component/summary-property.component.html b/ui/src/app/metadata/domain/component/summary-property.component.html
@@ -24,9 +24,11 @@
                         <tr *ngFor="let value of property.value">
                             <td *ngFor="let prop of getKeys(property.items)"
                                 [ngbPopover]="value[prop]"
+                                popoverClass="popover-lg"
                                 triggers="mouseenter:mouseleave"
                                 container="body"
-                                placement="top">
+                                placement="top"
+                                class="break-all">
                                 {{ value[prop] }}
                             </td>
                         </tr>

diff --git a/ui/src/app/schema-form/widget/check/checklist.component.html b/ui/src/app/schema-form/widget/check/checklist.component.html
@@ -23,7 +23,7 @@
                                 role="checkbox"
                                 aria-checked="false"
                             />
-                            <label class="custom-control-label" for="input-{{ i }}">
+                            <label class="custom-control-label" [for]="formProperty._canonicalPath + '.' + i">
                                 <span class="sr-only">
                                     <translate-i18n key="action.toggle">Toggle</translate-i18n> {{ attr.label | translate }}
                                 </span>

diff --git a/ui/src/theme/utility.scss b/ui/src/theme/utility.scss
@@ -12,4 +12,8 @@
 
 .w-40 {
     width: 40%;
-}
+}
+
+.break-all {
+    word-break: break-all;
+}