SHIBUI-1774

minor cleanup
TIER · Jun 26, 2021 · 0a6d994 · 0a6d994
1 parent c252b63
commit 0a6d994
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/pac4j-module/build.gradle b/pac4j-module/build.gradle
@@ -25,7 +25,7 @@ dependencyManagement {
 dependencies {
     compileOnly project(':backend')
 
-    compile "org.pac4j:spring-security-pac4j:6.0.0"
+    compile "org.pac4j:spring-security-pac4j:6.0.0" // pac4j is "off" - spring 6.0.0 here uses 5.1 core, thus differences in versions 
     compile "org.pac4j:pac4j-http:5.1.0"
     compile "org.pac4j:pac4j-saml:5.1.0", {
         // opensaml libraries are provided

diff --git a/pac4j-module/src/main/java/net/unicon/shibui/pac4j/WebSecurity.java b/pac4j-module/src/main/java/net/unicon/shibui/pac4j/WebSecurity.java
@@ -57,7 +57,7 @@ protected void configure(HttpSecurity http) throws Exception {
 
             final CallbackFilter callbackFilter = new CallbackFilter(this.config);
             http.antMatcher("/**").addFilterBefore(callbackFilter, BasicAuthenticationFilter.class)
-                                  .addFilterBefore(securityFilterForHeader, BasicAuthenticationFilter.class)  //xxx check on this
+                                  .addFilterBefore(securityFilterForHeader, BasicAuthenticationFilter.class)
                                   .addFilterAfter(new AddNewUserFilter(pac4jConfigurationProperties, userRepository, roleRepository, emailService), SecurityFilter.class);
 
             http.authorizeRequests().anyRequest().fullyAuthenticated();