Skip to content

Commit

Permalink
Merge branch 'master' into SHIBUI-754
Browse files Browse the repository at this point in the history
  • Loading branch information
dima767 committed Aug 20, 2018
2 parents c9520b9 + b8cc2ab commit 12bab6b
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 21 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,9 @@ export class ProviderFilterListComponent implements OnDestroy {
this.filters$ = this.store.select(fromFilter.getAdditionalFilters);
this.provider$ = this.store.select(fromProvider.getSelectedProvider).pipe(skipWhile(p => !p));
this.provider$
.pipe(takeUntil(this.ngUnsubscribe))
.pipe(
takeUntil(this.ngUnsubscribe)
)
.subscribe(p => {
this.store.dispatch(new LoadFilterRequest(p.resourceId));
});
Expand Down
Original file line number Diff line number Diff line change
@@ -1 +1,3 @@
<router-outlet></router-outlet>
<ng-container *ngIf="provider$ | async">
<router-outlet></router-outlet>
</ng-container>
10 changes: 0 additions & 10 deletions ui/src/app/shared/autocomplete/autocomplete.component.html
Original file line number Diff line number Diff line change
Expand Up @@ -50,15 +50,5 @@
<li class="dropdown-item dropdown-item-noresults" *ngIf="matches && matches.length === 0 && !processing">
{{ noneFoundText }}
</li>
<li class="dropdown-item"
*ngIf="showMoreAvailable && matches"
[class.active]="state.currentState.selected === matches.length"
[class.focused]="state.currentState.focused === matches.length"
(click)="handleViewMore($event)"
(mousedown)="handleViewMore($event)"
(keydown.enter)="handleViewMore($event)"
[id]="this.getOptionId(matches.length)">
{{ showMoreText }}
</li>
</ul>
</div>
9 changes: 1 addition & 8 deletions ui/src/app/shared/autocomplete/autocomplete.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,13 +40,12 @@ const INPUT_FIELD_INDEX = -1;
}
]
})
export class AutoCompleteComponent implements OnInit, OnDestroy, OnChanges, AfterViewInit, ControlValueAccessor {
export class AutoCompleteComponent implements OnInit, OnDestroy, AfterViewInit, ControlValueAccessor {
@Input() defaultValue = '';
@Input() matches: string[] = [];
@Input() id: string;
@Input() autoSelect = false;
@Input() noneFoundText = 'No Options Found';
@Input() showMoreText = 'Show More...';
@Input() limit = 0;
@Input() processing = false;
@Input() dropdown = false;
Expand Down Expand Up @@ -119,12 +118,6 @@ export class AutoCompleteComponent implements OnInit, OnDestroy, OnChanges, Afte
this.listItems.changes.subscribe((changes) => this.setElementReferences(changes));
}

ngOnChanges(changes: SimpleChanges): void {
if (changes.matches) {
this.showMoreAvailable = !!this.limit && this.matches && this.matches.length >= this.limit;
}
}

writeValue(value: any): void {
this.input.setValue(value);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@
"type": "section",
"fields": [
"name",
"@type"
"@type",
"enabled"
]
},
{
Expand Down Expand Up @@ -96,6 +97,12 @@
}
]
},
"enabled": {
"title": "Enable this service?",
"description": "Enable this service?",
"type": "boolean",
"default": false
},
"xmlId": {
"title": "ID",
"description": "Identifier for logging, identification for command line reload, etc.",
Expand Down

0 comments on commit 12bab6b

Please sign in to comment.