Skip to content

Commit

Permalink
added ids to info icons
Browse files Browse the repository at this point in the history
  • Loading branch information
rmathis committed Dec 1, 2022
1 parent 5ac148f commit 1b88cec
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
4 changes: 2 additions & 2 deletions ui/src/app/admin/container/ConfigurationList.js
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ export function ConfigurationList({ configurations, onDelete, loading }) {
</Popover>
)}
aria-label={translate('')}>
<Button onClick={() => download(c.resourceId, 'single')} variant="link" disabled={downloader.loading}>
<Button onClick={() => download(c.resourceId, 'single')} variant="link" disabled={downloader.loading} id="info-tooltip.download-single-config">
<FontAwesomeIcon icon={faDownload} />
&nbsp; <Translate value="action.download-single-config">Single file</Translate>
</Button>
Expand All @@ -107,7 +107,7 @@ export function ConfigurationList({ configurations, onDelete, loading }) {
</Popover>
)}
aria-label={translate('')}>
<Button onClick={() => download(c.resourceId, 'multi')} variant="link" disabled={downloader.loading}>
<Button onClick={() => download(c.resourceId, 'multi')} variant="link" disabled={downloader.loading} id={`info-tooltip.download-multi-config`}>
<FontAwesomeIcon icon={faDownload} />
&nbsp; <Translate value="action.download-multi-config">Multi file</Translate>
</Button>
Expand Down
2 changes: 1 addition & 1 deletion ui/src/app/form/component/InfoIcon.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export function InfoIcon ({ value = '', placement='auto', ...props }) {
</Popover>
)}
aria-label={translate('tooltip.instruction')}>
<Button variant="text" className="info-icon">
<Button variant="text" className="info-icon" id={`info-${value}`}>
<span className="sr-only">Description</span>
<FontAwesomeIcon className="text-primary" icon={faInfoCircle} size="lg" {...props} />
</Button>
Expand Down
3 changes: 2 additions & 1 deletion ui/src/app/metadata/component/properties/PropertyValue.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@ export function PropertyValue ({ name, value, columns, className }) {
<span
className={`d-block text-truncate ${className}`}
role="definition"
style={columns ? { width } : {}}>
style={columns ? { width } : {}}
id={`info-${value.toString()}`}>
<Translate value={value !== undefined ? value.toString() : (value === false) ? value.toString() : '-'}>
{value !== undefined ? value.toString() : (value === false) ? value.toString() : '-'}
</Translate>
Expand Down

0 comments on commit 1b88cec

Please sign in to comment.