SHIBUI-754: wip

TIER · Aug 17, 2018 · 1eeff24 · 1eeff24
1 parent 29ba7bd
commit 1eeff24
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/...internet2/tier/shibboleth/admin/ui/controller/MetadataFiltersPositionOrderController.java b/...internet2/tier/shibboleth/admin/ui/controller/MetadataFiltersPositionOrderController.java
@@ -47,10 +47,14 @@ public ResponseEntity<?> updateFiltersPositionOrder(@PathVariable String metadat
                         .ifPresent(reOrderedFilters::add)
         );
 
-        resolver.setMetadataFilters(reOrderedFilters);
-        metadataResolverRepository.save(resolver);
-
-        return ResponseEntity.noContent().build();
+        if(currentFilters.size() == reOrderedFilters.size()) {
+            resolver.setMetadataFilters(reOrderedFilters);
+            metadataResolverRepository.save(resolver);
+            return ResponseEntity.noContent().build();
+        }
+        return ResponseEntity
+                .badRequest()
+                .body("Number of filters to reorder or filters resource ids do not match current filters");
     }
 
     @GetMapping