Skip to content

Commit

Permalink
SHIBUI-996 Fixed validation of filter names
Browse files Browse the repository at this point in the history
  • Loading branch information
rmathis committed Nov 30, 2018
1 parent bfceb8c commit 2091f7c
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 14 deletions.
8 changes: 0 additions & 8 deletions ui/src/app/metadata/filter/effect/collection.effect.ts
Original file line number Diff line number Diff line change
Expand Up @@ -166,14 +166,6 @@ export class FilterCollectionEffects {
)
);

/*
@Effect()
reloadOrderAfterChange$ = this.actions$.pipe(
ofType<SetOrderFilterSuccess>(FilterCollectionActionTypes.SET_ORDER_FILTER_SUCCESS),
map(() => new GetOrderFilterRequest())
);
*/

@Effect()
setOrder$ = this.actions$.pipe(
ofType<SetOrderFilterRequest>(FilterCollectionActionTypes.SET_ORDER_FILTER_REQUEST),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,6 @@ export class ProviderSelectComponent implements OnDestroy {
map(params => new SelectProviderRequest(params.providerId))
).subscribe(store);

this.route.params.subscribe(params => console.log(params));

this.provider$ = this.store.select(fromProviders.getSelectedProvider).pipe(skipWhile(p => !p));

this.provider$.subscribe(provider => this.setDefinition(provider));
Expand Down
8 changes: 4 additions & 4 deletions ui/src/app/metadata/provider/provider.routing.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,6 @@ export const ProviderRoutes: Routes = [
path: '',
component: FilterComponent,
children: [
{
path: 'filters',
component: ProviderFilterListComponent
},
{
path: 'filter/new',
component: NewFilterComponent
Expand All @@ -62,6 +58,10 @@ export const ProviderRoutes: Routes = [
}
]
},
{
path: 'filters',
component: ProviderFilterListComponent
},
{
path: 'edit',
component: ProviderEditComponent,
Expand Down

0 comments on commit 2091f7c

Please sign in to comment.