SHIBUI-1934 Fixed filter list link

TIER · Jun 9, 2021 · 23ae5c5 · 23ae5c5
1 parent f30f4ec
commit 23ae5c5
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 5 deletions.
diff --git a/ui/src/app/metadata/domain/index.js b/ui/src/app/metadata/domain/index.js
@@ -1,6 +1,9 @@
 import { CustomAttributeDefinition } from './attribute/CustomAttributeDefinition';
 import { MetadataFilterEditorTypes } from './filter';
 import { MetadataProviderEditorTypes, MetadataProviderWizardTypes } from './provider';
+import { DynamicHttpMetadataProviderEditor } from './provider/DynamicHttpMetadataProviderDefinition';
+import { FileBackedHttpMetadataProviderEditor } from './provider/FileBackedHttpMetadataProviderDefinition';
+import { LocalDynamicMetadataProviderEditor } from './provider/LocalDynamicMetadataProviderDefinition';
 import { SourceEditor, SourceWizard } from "./source/SourceDefinition";
 
 export const editors = {
@@ -23,7 +26,13 @@ export const FilterEditorTypes = [
 
 export const AttributeEditorTypes = [
     CustomAttributeDefinition
-]
+];
+
+export const FilterableProviders = [
+    FileBackedHttpMetadataProviderEditor.type,
+    DynamicHttpMetadataProviderEditor.type,
+    LocalDynamicMetadataProviderEditor.type
+];
 
 export const getWizard = (type) =>
     ProviderWizardTypes.find(def => def.type === type) ||

diff --git a/ui/src/app/metadata/editor/MetadataEditor.js b/ui/src/app/metadata/editor/MetadataEditor.js
@@ -15,6 +15,7 @@ import { NavLink } from 'react-router-dom';
 import { useTranslator } from '../../i18n/hooks';
 import API_BASE_PATH from '../../App.constant';
 import { MetadataObjectContext } from '../hoc/MetadataSelector';
+import { FilterableProviders } from '../domain/provider';
 
 export function MetadataEditor ({ current }) {
 
@@ -68,6 +69,8 @@ export function MetadataEditor ({ current }) {
 
     const warnings = definition.warnings && definition.warnings(metadata);
 
+    const canFilter = FilterableProviders.indexOf(definition.type) > -1;
+
     return (
         <div className="container-fluid p-3">
             <Prompt
@@ -97,12 +100,12 @@ export function MetadataEditor ({ current }) {
                                 base={`/metadata/${type}/${id}/edit`}
                                 format='dropdown'
                                 errors={errors}>
-                                <NavLink className="dropdown-item"
+                                {canFilter && <NavLink className="dropdown-item"
                                     to="../filter/list"
                                     aria-label={translator('label.filter-list')}
                                     role="button">
                                     <Translate value="label.filter-list"></Translate>
-                                </NavLink>
+                                </NavLink>}
                             </MetadataEditorNav>
                         </div>
                         <div className="col-6 col-lg-3 order-2 text-right">
@@ -152,12 +155,12 @@ export function MetadataEditor ({ current }) {
                                 base={`/metadata/${type}/${id}/edit`}
                                 format='tabs'
                                 errors={errors}>
-                                <NavLink className="nav-link"
+                                {canFilter && <NavLink className="nav-link"
                                     to="../filter/list"
                                     aria-label={translator('label.filter-list')}
                                     role="button">
                                     <Translate value="label.filter-list"></Translate>
-                                </NavLink>
+                                </NavLink> }
                             </MetadataEditorNav>
                         </div>
                         <div className="col-lg-9">