Skip to content

Commit

Permalink
Fixed test, updated icon
Browse files Browse the repository at this point in the history
  • Loading branch information
rmathis committed Sep 1, 2021
1 parent 786d737 commit 271727f
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 4 deletions.
6 changes: 3 additions & 3 deletions ui/src/app/core/components/Header.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import OverlayTrigger from 'react-bootstrap/OverlayTrigger';
import Tooltip from 'react-bootstrap/Tooltip';

import { FontAwesomeIcon } from '@fortawesome/react-fontawesome';
import { faTh, faSignOutAlt, faPlusCircle, faCube, faCubes, faUsersCog, faUser, faSpinner, faUserCircle } from '@fortawesome/free-solid-svg-icons';
import { faTh, faSignOutAlt, faPlusCircle, faCube, faCubes, faUsersCog, faUser, faSpinner, faUserCircle, faCog } from '@fortawesome/free-solid-svg-icons';

import Translate from '../../i18n/components/translate';
import { useTranslator } from '../../i18n/hooks';
Expand Down Expand Up @@ -67,7 +67,7 @@ export function Header () {
{isAdmin &&
<Dropdown className="border-md-right px-2" id="basic-nav-dropdown">
<Dropdown.Toggle variant="link" id="dropdown-basic" size="sm">
<FontAwesomeIcon icon={faPlusCircle} className="mr-2" />
<FontAwesomeIcon icon={faCog} className="mr-2" />
<Translate value={'action.advanced'} />
</Dropdown.Toggle>
<Dropdown.Menu>
Expand All @@ -84,7 +84,7 @@ export function Header () {
}
<Dropdown className="pl-2" id="basic-nav-dropdown">
<Dropdown.Toggle variant="link" id="dropdown-basic" size="sm" bsPrefix="dropdown-toggle-shibui">
<FontAwesomeIcon icon={faUserCircle} size="" className="mr-2" />
<FontAwesomeIcon icon={faUserCircle} size="lg" className="mr-2" />
<Translate value={'action.logged-in'} params={{ username }} />
</Dropdown.Toggle>
<Dropdown.Menu alignRight={true}>
Expand Down
8 changes: 7 additions & 1 deletion ui/src/app/core/components/Header.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,20 @@ jest.mock('../../i18n/hooks', () => ({
}));

const mockIsAdmin = jest.fn();
const mockCurrentUser = jest.fn();
const mockCurrentUserLoading = jest.fn();

jest.mock('../user/UserContext', () => ({
useIsAdmin: () => mockIsAdmin()
useIsAdmin: () => mockIsAdmin(),
useCurrentUser: () => mockCurrentUser(),
useCurrentUserLoading: () => mockCurrentUserLoading()
}));

describe('header for admins', () => {
beforeEach(() => {
mockIsAdmin.mockReturnValue(true);
mockCurrentUser.mockReturnValue({ username: 'foo', groupId: 'bar' });
mockCurrentUserLoading.mockReturnValue(false);
});

it('should display logo and navigation', () => {
Expand Down

0 comments on commit 271727f

Please sign in to comment.