Skip to content

Commit

Permalink
Merge branch 'master' into feature/SHIBUI-1408-QA
Browse files Browse the repository at this point in the history
  • Loading branch information
Bill Smith committed Oct 7, 2019
2 parents 6b94295 + 2e02472 commit 315e888
Show file tree
Hide file tree
Showing 9 changed files with 24 additions and 218 deletions.
14 changes: 0 additions & 14 deletions ui/src/app/metadata/domain/component/wizard-summary.component.html

This file was deleted.

103 changes: 0 additions & 103 deletions ui/src/app/metadata/domain/component/wizard-summary.component.spec.ts

This file was deleted.

80 changes: 0 additions & 80 deletions ui/src/app/metadata/domain/component/wizard-summary.component.ts

This file was deleted.

2 changes: 0 additions & 2 deletions ui/src/app/metadata/domain/domain.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,8 @@ import { UnsavedEntityComponent } from './component/unsaved-entity.dialog';
import { EditorNavComponent } from './component/editor-nav.component';
import { RouterModule } from '@angular/router';
import { SharedModule } from '../../shared/shared.module';
import { WizardSummaryComponent } from './component/wizard-summary.component';

export const COMPONENTS = [
WizardSummaryComponent,
PreviewDialogComponent,
UnsavedEntityComponent,
SummaryPropertyComponent,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,12 @@
<router-outlet></router-outlet>
</div>
</div>
<wizard-summary
[summary]="summary$ | async"
(onPageSelect)="gotoPage($event)"
*ngIf="currentPage === 'summary'">
</wizard-summary>
<div *ngIf="currentPage === 'summary'">
<metadata-configuration
[configuration]="summary$ | async"
(onEdit)="gotoPage($event)"
id="configuration"></metadata-configuration>
</div>
</div>
</div>
</section>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ import { NgbDropdownModule, NgbPopoverModule } from '@ng-bootstrap/ng-bootstrap'
import { ProviderWizardComponent } from './provider-wizard.component';
import * as fromRoot from '../reducer';
import { WizardModule } from '../../../wizard/wizard.module';
import { WizardSummaryComponent } from '../../domain/component/wizard-summary.component';
import { SummaryPropertyComponent } from '../../domain/component/summary-property.component';
import * as fromWizard from '../../../wizard/reducer';
import { MockI18nModule } from '../../../../testing/i18n.stub';
import { MetadataConfigurationComponentStub } from '../../../../testing/metadata-configuration.stub';

@Component({
template: `
Expand Down Expand Up @@ -46,7 +46,7 @@ describe('Provider Wizard Component', () => {
declarations: [
ProviderWizardComponent,
SummaryPropertyComponent,
WizardSummaryComponent,
MetadataConfigurationComponentStub,
TestHostComponent
]
}).compileComponents();
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { Component, OnDestroy } from '@angular/core';
import { Observable, combineLatest, Subject } from 'rxjs';
import { Observable, Subject } from 'rxjs';
import { Store } from '@ngrx/store';

import * as fromProvider from '../reducer';
Expand All @@ -11,9 +11,9 @@ import { startWith, takeUntil } from 'rxjs/operators';
import { Wizard, WizardStep } from '../../../wizard/model';
import { MetadataProvider } from '../../domain/model';
import { ClearProvider } from '../action/entity.action';
import { map } from 'rxjs/operators';
import { AddProviderRequest } from '../action/collection.action';
import { MetadataProviderWizard } from '../model';
import { MetadataConfiguration } from '../../configuration/model/metadata-configuration';

@Component({
selector: 'provider-wizard',
Expand All @@ -33,7 +33,7 @@ export class ProviderWizardComponent implements OnDestroy {
nextStep: WizardStep;
previousStep: WizardStep;

summary$: Observable<{ definition: Wizard<MetadataProvider>, schema: { [id: string]: any }, model: any }>;
summary$: Observable<MetadataConfiguration> = this.store.select(fromProvider.getProviderConfiguration);

provider: MetadataProvider;

Expand Down Expand Up @@ -61,14 +61,6 @@ export class ProviderWizardComponent implements OnDestroy {
this.store.dispatch(new SetDisabled(!valid));
});

this.summary$ = combineLatest(
this.store.select(fromWizard.getWizardDefinition),
this.store.select(fromWizard.getParsedSchema),
this.store.select(fromProvider.getEntityChanges)
).pipe(
map(([ definition, schema, model ]) => ({ definition, schema, model }))
);

this.changes$.pipe(takeUntil(this.ngUnsubscribe)).subscribe(c => this.provider = c);

this.store.dispatch(new SetDefinition(MetadataProviderWizard));
Expand Down
4 changes: 3 additions & 1 deletion ui/src/app/metadata/provider/provider.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ import { I18nModule } from '../../i18n/i18n.module';
import { DomainModule } from '../domain/domain.module';
import { MetadataProviderPageComponent } from './provider.component';
import { FilterModule } from '../filter/filter.module';
import { MetadataConfigurationModule } from '../configuration/configuration.module';

@NgModule({
declarations: [
Expand Down Expand Up @@ -55,7 +56,8 @@ import { FilterModule } from '../filter/filter.module';
NgbModalModule,
I18nModule,
DomainModule,
FilterModule
FilterModule,
MetadataConfigurationModule
],
exports: []
})
Expand Down
10 changes: 10 additions & 0 deletions ui/src/app/metadata/provider/reducer/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import * as utils from '../../domain/domain.util';
import * as fromWizard from '../../../wizard/reducer';

import { MetadataProvider } from '../../domain/model';
import { getConfigurationSectionsFn } from '../../configuration/reducer/utilities';

export interface ProviderState {
editor: fromEditor.EditorState;
Expand Down Expand Up @@ -79,3 +80,12 @@ export const getOrderedProviders = createSelector(getAllProviders, getProviderOr
export const getOrderedProvidersInSearch = createSelector(getAllProviders, getProviderOrder, utils.mergeOrderFn);

export const getFilteredProviderXmlIds = createSelector(getProviderXmlIds, getSelectedProvider, getFilteredListFn('xmlId'));

export const getProviderModelList = createSelector(getEntityChanges, (model) => [model]);

export const getProviderConfiguration = createSelector(
getProviderModelList,
fromWizard.getWizardDefinition,
fromWizard.getProcessedSchema,
getConfigurationSectionsFn
);

0 comments on commit 315e888

Please sign in to comment.