Skip to content

Commit

Permalink
Fixed loading spinner
Browse files Browse the repository at this point in the history
Former-commit-id: 81760a5d89c563c4cbb2b979cbeaf6251fd77d80
  • Loading branch information
rmathis committed Jul 28, 2022
1 parent 953f1fd commit 34b46b7
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
6 changes: 1 addition & 5 deletions ui/src/app/metadata/view/MetadataWizard.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import { useMetadataEntity } from '../hooks/api';
import { createNotificationAction, NotificationTypes, useNotificationDispatcher } from '../../notifications/hoc/Notifications';
import { Prompt, useHistory } from 'react-router-dom';
import { useTranslator } from '../../i18n/hooks';
import Spinner from '../../core/components/Spinner';

export function MetadataWizard ({type, data, onCallback}) {

Expand Down Expand Up @@ -58,10 +57,7 @@ export function MetadataWizard ({type, data, onCallback}) {
/>
<Wizard>
{type === 'source' ?
<React.Fragment>
<MetadataSourceWizard onSave={save} loading={loading} block={setBlocking} onShowNav={onCallback} />
{loading && <div className="d-flex justify-content-center text-primary col-6"><Spinner size="4x" /></div> }
</React.Fragment>
<MetadataSourceWizard onSave={save} loading={loading} block={setBlocking} onShowNav={onCallback} />
:
<MetadataProviderWizard onSave={save} loading={loading} block={setBlocking} onRestart={onCallback} />
}
Expand Down
5 changes: 4 additions & 1 deletion ui/src/app/metadata/wizard/MetadataSourceWizard.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import Col from 'react-bootstrap/Col';
import { WizardNav } from './WizardNav';
import { MetadataWizardForm } from './MetadataWizardForm';
import { setWizardIndexAction, useCurrentIndex, useIsFirstPage, useIsLastPage, useWizardDispatcher } from './Wizard';
import { useMetadataDefinitionContext, useMetadataSchemaContext, useMetadataDefinitionValidator } from '../hoc/MetadataSchema';
import { useMetadataDefinitionContext, useMetadataSchemaContext, useMetadataDefinitionValidator, useMetadataSchemaLoading } from '../hoc/MetadataSchema';
import { useMetadataFormDispatcher, setFormDataAction, setFormErrorAction, useMetadataFormData, useMetadataFormErrors } from '../hoc/MetadataFormContext';
import { MetadataConfiguration } from '../component/MetadataConfiguration';
import { Configuration } from '../hoc/Configuration';
Expand All @@ -17,13 +17,15 @@ import { useMetadataSources } from '../hooks/api';
import Translate from '../../i18n/components/translate';
import { checkChanges } from '../hooks/utility';
import { useCurrentUserLoader, useUserGroup } from '../../core/user/UserContext';
import Spinner from '../../core/components/Spinner';


export function MetadataSourceWizard ({ onShowNav, onSave, block, loading }) {

const group = useUserGroup();

const userLoader = useCurrentUserLoader();
const schemaLoading = useMetadataSchemaLoading();

/*eslint-disable react-hooks/exhaustive-deps*/
React.useEffect(() => {
Expand Down Expand Up @@ -75,6 +77,7 @@ export function MetadataSourceWizard ({ onShowNav, onSave, block, loading }) {
</div>
</div>
<hr />
{schemaLoading && <div className="d-flex justify-content-center text-primary col-6"><Spinner size="4x" /></div> }
{warnings && warnings.hasOwnProperty(current) &&
<Row className="mb-4">
<Col xs="12" lg="6" className="align-items-start">
Expand Down

0 comments on commit 34b46b7

Please sign in to comment.