Skip to content

Commit

Permalink
SHIBUI-598 Moving type files
Browse files Browse the repository at this point in the history
  • Loading branch information
rmathis committed Jun 13, 2018
1 parent 7b32bfd commit 389c564
Show file tree
Hide file tree
Showing 10 changed files with 47 additions and 107 deletions.
14 changes: 0 additions & 14 deletions ui/src/app/domain/domain.type.ts

This file was deleted.

12 changes: 0 additions & 12 deletions ui/src/app/domain/model/metadata-base.ts

This file was deleted.

31 changes: 27 additions & 4 deletions ui/src/app/metadata/domain/domain.type.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,36 @@ import {
MetadataFilter
} from './model';

import {
EntityAttributesFilter,
FileBackedHttpMetadataResolver,
FileBackedHttpMetadataProvider
} from './entity';

export type Filter =
| EntityAttributesFilter;

export type Resolver =
| FileBackedHttpMetadataResolver;

export type Provider =
| FileBackedHttpMetadataProvider;

export type Entity =
| Filter
| Resolver
| Provider;

export type Metadata =
| MetadataProvider
| MetadataResolver
| MetadataFilter;

export enum MetadataTypes {
FILTER = '[Type] Metadata Filter',
PROVIDER = '[Type] Metadata Provider',
RESOLVER = '[Type] Metadata Resolver'
}

export type Metadata =
| MetadataProvider
| MetadataResolver
| MetadataFilter;
export * from './model';
export * from './entity';
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import { MetadataFilter, RelyingPartyOverrides } from '../model/metadata-filter';
import { DomainEntityKinds } from '../domain.type';
import { FilterTarget } from '../model/filter-target';
import { MetadataFilter, MetadataEntity, RelyingPartyOverrides } from '../../model';
import { MetadataTypes } from '../../domain.type';
import { FilterTarget } from '../../model';

export class EntityAttributesFilter implements MetadataFilter {
export class EntityAttributesFilter implements MetadataFilter, MetadataEntity {
createdDate?: string;
modifiedDate?: string;
version: string;
Expand Down Expand Up @@ -42,7 +42,7 @@ export class EntityAttributesFilter implements MetadataFilter {
}

get kind(): string {
return DomainEntityKinds.filter;
return MetadataTypes.FILTER;
}

get entityId(): string {
Expand Down
3 changes: 3 additions & 0 deletions ui/src/app/metadata/domain/entity/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
export * from './filter/entity-attributes-filter';
export * from './provider/file-backed-http-metadata-provider';
export * from './resolver/file-backed-http-metadata-resolver';
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@ import {
SsoService,
IdpSsoDescriptor,
RelyingPartyOverrides
} from '../model';
import { MetadataTypes } from '../domain.type';
} from '../../model';
import { MetadataTypes } from '../../domain.type';

export class Provider implements MetadataProvider, MetadataEntity {
export class FileBackedHttpMetadataProvider implements MetadataProvider, MetadataEntity {
id = '';
createdDate?: string;
modifiedDate?: string;
Expand Down Expand Up @@ -61,7 +61,7 @@ export class Provider implements MetadataProvider, MetadataEntity {
}

get kind(): string {
return DomainEntityKinds.provider;
return MetadataTypes.PROVIDER;
}

serialize(): any {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Resolver } from './resolver.entity';
import { FileBackedHttpMetadataResolver } from './file-backed-http-metadata-resolver';

describe('Resolver construct', () => {

Expand Down Expand Up @@ -83,7 +83,7 @@ describe('Resolver construct', () => {
'mail'
]
};
const entity = new Resolver(config);
const entity = new FileBackedHttpMetadataResolver(config);

it('should populate its own values', () => {
Object.keys(config).forEach(key => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,11 @@ import {
SsoService,
IdpSsoDescriptor,
RelyingPartyOverrides
} from '../model';
import { MetadataTypes } from '../domain.type';
import { MetadataEntity } from '../model/metadata-entity';
} from '../../model';
import { MetadataTypes } from '../../domain.type';
import { MetadataEntity } from '../../model/metadata-entity';

export class Resolver implements MetadataProvider, MetadataEntity {
export class FileBackedHttpMetadataResolver implements MetadataProvider, MetadataEntity {
id = '';
createdDate?: string;
modifiedDate?: string;
Expand Down Expand Up @@ -60,7 +60,7 @@ export class Resolver implements MetadataProvider, MetadataEntity {
return this.serviceEnabled;
}

get type(): string {
get kind(): string {
return MetadataTypes.RESOLVER;
}

Expand Down
60 changes: 0 additions & 60 deletions ui/src/app/metadata/domain/model/filter.entity.ts

This file was deleted.

2 changes: 1 addition & 1 deletion ui/src/app/metadata/domain/model/metadata-entity.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
export interface MetadataEntity {
name: string;
enabled: boolean;
type: string;
kind: string;

serialize(): any;
}

0 comments on commit 389c564

Please sign in to comment.