SHIBUI-2394

SHIBUI-2447 fixed issue with items with no defined approvers needing approval
TIER · Nov 2, 2022 · 5c20b23 · 5c20b23
1 parent 7e19acc
commit 5c20b23
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/...n/java/edu/internet2/tier/shibboleth/admin/ui/service/JPAEntityDescriptorServiceImpl.java b/...n/java/edu/internet2/tier/shibboleth/admin/ui/service/JPAEntityDescriptorServiceImpl.java
@@ -231,7 +231,7 @@ public EntityDescriptorRepresentation createNew(EntityDescriptorRepresentation e
 
         EntityDescriptor ed = (EntityDescriptor) createDescriptorFromRepresentation(edRep);
         ed.setIdOfOwner(userService.getCurrentUserGroup().getOwnerId());
-        if (userService.currentUserIsAdmin()) {
+        if (userService.currentUserIsAdmin() || userService.getCurrentUserGroup().getApproversList().isEmpty()) {
             ed.setApproved(true);
         }
 
@@ -250,7 +250,7 @@ public EntityDescriptorRepresentation createNewEntityDescriptorFromXMLOrigin(Ent
         if (ed.getProtocol() == EntityDescriptorProtocol.OIDC) {
             ed.getSPSSODescriptor("").addSupportedProtocol("http://openid.net/specs/openid-connect-core-1_0.html");
         }
-        if (userService.currentUserIsAdmin()) {
+        if (userService.currentUserIsAdmin() || userService.getCurrentUserGroup().getApproversList().isEmpty()) {
             ed.setApproved(true);
         }
         EntityDescriptor savedEntity = entityDescriptorRepository.save(ed);