Address code review

beacon/core/build.gradle

@@ -1,12 +1,29 @@
-apply plugin: 'java'
+import org.springframework.boot.gradle.plugin.SpringBootPlugin
+
+plugins {
+    id 'org.springframework.boot' version '2.0.0.RELEASE' apply false
+    id 'io.spring.dependency-management' version '1.0.6.RELEASE'
+}
+
+apply plugin: 'groovy'
 sourceCompatibility = 1.8
 targetCompatibility = 1.8
 
 repositories {
     jcenter()
 }
 
+dependencyManagement {
+    imports {
+        mavenBom SpringBootPlugin.BOM_COORDINATES
+    }
+}
+
 dependencies {
+    testCompile "org.springframework.boot:spring-boot-starter-test"
+    testCompile "org.spockframework:spock-core:1.1-groovy-2.4"
+    testCompile "org.spockframework:spock-spring:1.1-groovy-2.4"
+
     testCompile 'org.junit.jupiter:junit-jupiter-api:5.5.2'
     testCompile 'org.junit.jupiter:junit-jupiter-engine:5.5.2'
 }
@@ -15,6 +32,6 @@ jar {
     archiveName = "beacon-core-${version}.jar"
 }
 
-test {
+/*test {
     useJUnitPlatform()
-}
+}*/

beacon/core/src/main/java/edu/internet2/tap/beacon/DefaultBeaconPublisher.java

@@ -24,9 +24,9 @@
  */
 public class DefaultBeaconPublisher implements BeaconPublisher {
 
-    private URL endpointUrl;
+    private final URL endpointUrl;
 
-    private String jsonPayload;
+    private final String jsonPayload;
 
     public DefaultBeaconPublisher(Map<String, String> beaconDetails) {
         //Do data validation checks here. If any of the necessary beacon data not available here, throw a Runtime exception

beacon/core/src/test/groovy/edu/internet2/tap/beacon/DefaultBeaconPublisherTests.groovy

@@ -0,0 +1,45 @@
+package edu.internet2.tap.beacon
+
+import spock.lang.Specification
+import sun.security.x509.OtherName
+
+class DefaultBeaconPublisherTests extends Specification {
+
+    def "DefaultBeaconPublisher invariants are enforced during object creation - null Map is passed"() {
+        when:
+        new DefaultBeaconPublisher(null)
+
+        then:
+        thrown IllegalArgumentException
+
+    }
+
+    def "DefaultBeaconPublisher invariants are enforced during object creation - empty Map is passed"() {
+        when:
+        new DefaultBeaconPublisher([:])
+
+        then:
+        thrown IllegalArgumentException
+    }
+
+    def "DefaultBeaconPublisher invariants are enforced during object creation - valid Beacon data Map is passed"() {
+        when:
+        def expectedJsonPaylaod = """{"msgType":"TIERBEACON", "tbMaintainer":"unittest_maintainer", "msgName":"TIER", "tbProduct":"image", "msgVersion":"1.0", "tbProductVersion":"v1", "tbTIERRelease":"tv1"}"""
+
+        def configuredBeaconData = [LOGHOST   : 'collector.testbed.tier.internet2.edu',
+                                    LOGPORT   : '5001',
+                                    IMAGE      : 'image',
+                                    VERSION    : 'v1',
+                                    TIERVERSION: 'tv1',
+                                    MAINTAINER : 'unittest_maintainer']
+        def p = new DefaultBeaconPublisher(configuredBeaconData)
+        println p.jsonPayload
+
+        then:
+        noExceptionThrown()
+        p.endpointUri == 'http://collector.testbed.tier.internet2.edu:5001'
+        p.jsonPayload == expectedJsonPaylaod
+
+    }
+
+}