Skip to content

Commit

Permalink
[SHIBUI-570]
Browse files Browse the repository at this point in the history
Swapped MetadataResolverConverterServiceImpl's @Service annotation out
for a new Configuration class with a new Bean declaration. How was this
even working?

Updated OpenSamlChainingMetadataResolver to initialize mutableResolvers
with a new ArrayList instead of Collections.emptyList. Big mistake. Also,
overrode resolve() to use the mutableResolvers list instead of the (empty)
original resolvers list.

Added new OpenSamlBatchMetadataResolverDelegate to handle refilter().
Added refilter() to all Batch-ish OpenSaml resolvers.

Removed refreshOrInitResolver from filter controller. Not needed.

Added refilter() calls in JPAMetadataResolverServiceImpl.reloadFilters.
  • Loading branch information
Bill Smith committed Sep 10, 2018
1 parent 459df71 commit 75013d0
Showing 1 changed file with 19 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
package edu.internet2.tier.shibboleth.admin.ui.domain.resolvers.opensaml;

import org.opensaml.core.xml.XMLObject;
import org.opensaml.saml.metadata.resolver.impl.AbstractBatchMetadataResolver;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

/**
* @author Bill Smith (wsmith@unicon.net)
*/
public class OpenSamlBatchMetadataResolverDelegate extends AbstractBatchMetadataResolver {
private static final Logger logger = LoggerFactory.getLogger(OpenSamlBatchMetadataResolverDelegate.class);

//TODO: Not sure this delegate is really buying us anything.. other than to get this one line in to a shared class.
//Maybe we'll do more in here later?
public void refilter(AbstractBatchMetadataResolver.BatchEntityBackingStore backingStore, XMLObject filteredMetadata) {
backingStore.setCachedFilteredMetadata(filteredMetadata);
}
}

0 comments on commit 75013d0

Please sign in to comment.