SHIBUI Added error notification when update fails

TIER · Feb 28, 2019 · 7f51cfc · 7f51cfc
1 parent dc6c4c5
commit 7f51cfc
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/ui/src/app/metadata/provider/action/collection.action.ts b/ui/src/app/metadata/provider/action/collection.action.ts
@@ -89,7 +89,7 @@ export class UpdateProviderSuccess implements Action {
 export class UpdateProviderFail implements Action {
     readonly type = ProviderCollectionActionTypes.UPDATE_PROVIDER_FAIL;
 
-    constructor(public payload: MetadataProvider) { }
+    constructor(public payload: any) { }
 }
 
 export class UpdateProviderConflict implements Action {

diff --git a/ui/src/app/metadata/provider/effect/collection.effect.ts b/ui/src/app/metadata/provider/effect/collection.effect.ts
@@ -144,7 +144,7 @@ export class CollectionEffects {
                 .update(provider)
                 .pipe(
                     map(p => new UpdateProviderSuccess({id: p.id, changes: p})),
-                    catchError((e) => e.status === 409 ? of(new UpdateProviderConflict(provider)) : of(new UpdateProviderFail(provider)))
+                    catchError((e) => e.status === 409 ? of(new UpdateProviderConflict(provider)) : of(new UpdateProviderFail(e.error)))
                 )
         )
     );
@@ -166,6 +166,20 @@ export class CollectionEffects {
         })
     );
 
+    @Effect()
+    updateProviderFailDispatchNotification$ = this.actions$.pipe(
+        ofType<UpdateProviderFail>(ProviderCollectionActionTypes.UPDATE_PROVIDER_FAIL),
+        map(action => action.payload),
+        withLatestFrom(this.store.select(fromI18n.getMessages)),
+        map(([error, messages]) => new AddNotification(
+            new Notification(
+                NotificationType.Danger,
+                `${error.errorCode}: ${this.i18nService.translate(error.errorMessage, null, messages)}`,
+                8000
+            )
+        ))
+    );
+
     @Effect()
     addProviderSuccessReload$ = this.actions$.pipe(
         ofType<AddProviderSuccess>(ProviderCollectionActionTypes.ADD_PROVIDER_SUCCESS),