Add TODO note about manipulating filters directly via FilterRepository

TIER · Aug 16, 2018 · 8c4945d · 8c4945d
1 parent c8bf479
commit 8c4945d
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/...ain/java/edu/internet2/tier/shibboleth/admin/ui/controller/MetadataFiltersController.java b/...ain/java/edu/internet2/tier/shibboleth/admin/ui/controller/MetadataFiltersController.java
@@ -130,6 +130,7 @@ public ResponseEntity<?> delete(@PathVariable String metadataResolverId,
                                     @PathVariable String resourceId) {
 
         MetadataResolver resolver = findResolverOrThrowHttp404(metadataResolverId);
+        //TODO: consider implementing delete of filter directly from RDBMS via FilterRepository
         boolean removed = resolver.getMetadataFilters().removeIf(f -> f.getResourceId().equals(resourceId));
         if(!removed) {
             throw HTTP_404_CLIENT_ERROR_EXCEPTION.get();