Skip to content

Commit

Permalink
Removed rxjs-compat
Browse files Browse the repository at this point in the history
  • Loading branch information
rmathis committed Oct 18, 2019
1 parent f89d977 commit 8eaea88
Show file tree
Hide file tree
Showing 14 changed files with 13 additions and 21 deletions.
5 changes: 0 additions & 5 deletions ui/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion ui/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@
"ngx-infinite-scroll": "^7.2.0",
"ngx-schema-form": "2.3.5",
"rxjs": "^6.5.3",
"rxjs-compat": "^6.5.1",
"xml-formatter": "^1.0.1",
"z-schema": "^3.22.0",
"zone.js": "~0.9.1"
Expand Down
2 changes: 1 addition & 1 deletion ui/src/app/core/effect/user.effect.spec.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { TestBed } from '@angular/core/testing';
import { provideMockActions } from '@ngrx/effects/testing';
import { ReplaySubject } from 'rxjs/ReplaySubject';
import { ReplaySubject } from 'rxjs';

import { UserEffects } from './user.effect';
import { Subject, of, throwError } from 'rxjs';
Expand Down
2 changes: 1 addition & 1 deletion ui/src/app/core/effect/version.effect.spec.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { TestBed } from '@angular/core/testing';
import { provideMockActions } from '@ngrx/effects/testing';
import { ReplaySubject } from 'rxjs/ReplaySubject';
import { ReplaySubject } from 'rxjs';

import { VersionEffects } from './version.effect';
import {
Expand Down
4 changes: 2 additions & 2 deletions ui/src/app/core/service/modal.service.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { Injectable } from '@angular/core';
import { Observable } from 'rxjs';
import { NgbModal, NgbModalOptions } from '@ng-bootstrap/ng-bootstrap';
import { fromPromise } from 'rxjs/observable/fromPromise';
import { from } from 'rxjs';

export const DEFAULT_MODAL_OPTIONS: NgbModalOptions = {
size: 'lg'
Expand All @@ -21,6 +21,6 @@ export class ModalService {
if (modal.hasOwnProperty('componentInstance')) {
Object.keys(inputs).forEach(key => modal.componentInstance[key] = inputs[key]);
}
return fromPromise(modal.result);
return from(modal.result);
}
} /* istanbul ignore next */
2 changes: 1 addition & 1 deletion ui/src/app/i18n/effect/message.effect.spec.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { TestBed } from '@angular/core/testing';
import { provideMockActions } from '@ngrx/effects/testing';
import { ReplaySubject } from 'rxjs/ReplaySubject';
import { ReplaySubject } from 'rxjs';

import { MessageEffects } from './message.effect';

Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { Component, Input } from '@angular/core';
import { NgbActiveModal } from '@ng-bootstrap/ng-bootstrap';
import * as FileSaver from 'file-saver';
import { Subscription } from 'rxjs/Subscription';
import { Subscription } from 'rxjs';
import { MetadataEntity } from '../../domain/model';

@Component({
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { Component, Input } from '@angular/core';

import { NgbActiveModal } from '@ng-bootstrap/ng-bootstrap';
import { Subject } from 'rxjs/Subject';
import { Subject } from 'rxjs';

@Component({
selector: 'unsaved-entity',
Expand Down
4 changes: 2 additions & 2 deletions ui/src/app/metadata/filter/effect/search.effect.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import {

import { SearchDialogComponent } from '../component/search-dialog.component';
import { EntityIdService } from '../../domain/service/entity-id.service';
import { fromPromise } from 'rxjs/internal-compatibility';
import { from } from 'rxjs';
import { SelectId } from '../action/filter.action';
import * as fromProvider from '../../provider/reducer';

Expand Down Expand Up @@ -50,7 +50,7 @@ export class SearchIdEffects {
const modal = this.modalService.open(SearchDialogComponent) as NgbModalRef;
const res = modal.result;
modal.componentInstance.term = q;
return fromPromise(res).pipe(
return from(res).pipe(
map(id => new SelectId(id)),
catchError(() => of(new CancelViewMore()))
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ export class ResolverWizardStepComponent implements OnDestroy {
this.model$
).pipe(
map(([def, ids, resolver]) => {
console.log(resolver);
return def.getValidators(
ids
);
Expand Down
2 changes: 1 addition & 1 deletion ui/src/test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import {
platformBrowserDynamicTesting
} from '@angular/platform-browser-dynamic/testing';

import 'rxjs/Rx';
import 'rxjs';

// Unfortunately there's no typing for the `__karma__` variable. Just declare it as any.
declare const __karma__: any;
Expand Down
4 changes: 2 additions & 2 deletions ui/src/testing/activated-route.stub.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
/* istanbul ignore */

import { Injectable } from '@angular/core';
import { BehaviorSubject } from 'rxjs/BehaviorSubject';
import { convertToParamMap, ParamMap, ActivatedRoute } from '@angular/router';
import { BehaviorSubject } from 'rxjs';
import { convertToParamMap, ParamMap } from '@angular/router';
import { Observable, of } from 'rxjs';

@Injectable()
Expand Down
2 changes: 1 addition & 1 deletion ui/src/testing/file.service.stub.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Subject } from 'rxjs/Subject';
import { Subject } from 'rxjs';
import { Observable } from 'rxjs';

export class FileServiceStub {
Expand Down
1 change: 0 additions & 1 deletion ui/src/testing/router.stub.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { Component, Directive, Input, Injectable } from '@angular/core';
import { BehaviorSubject } from 'rxjs/BehaviorSubject';
import { NavigationExtras } from '@angular/router';

/*tslint:disable*/
Expand Down

0 comments on commit 8eaea88

Please sign in to comment.