Merged in bugfix/SHIBUI-2502 (pull request #637)

Fixed issue when changing filter types Approved-by: Doug Sonaty
TIER · Feb 16, 2023 · 969c732 · 969c732
2 parents 3c21843 + 940d3cf
commit 969c732
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/ui/src/app/metadata/hoc/MetadataSchema.js b/ui/src/app/metadata/hoc/MetadataSchema.js
@@ -23,7 +23,7 @@ export function MetadataSchema({ type, children, wizard = false }) {
 
     const [schema, setSchema] = React.useState();
 
-    async function loadSchema(type) {
+    const loadSchema = React.useCallback(async (type) => {
         const definition = wizard ? getWizard(type) : getDefinition(type);
         setDefinition(definition);
         setKind(type);
@@ -34,11 +34,12 @@ export function MetadataSchema({ type, children, wizard = false }) {
             setSchema(source);
         }
         setLoading(false);
-    }
+    }, [response.ok, get, wizard]);
 
-    React.useState(() => {
+    React.useEffect(() => {
         loadSchema(type);
-    }, [type]);
+        setSchema(null);
+    }, [type, loadSchema]);
 
     return (
         <MetadataDefinitionContext.Provider value={definition}>