SHIBUI-2394

Fixes for group/approver edits and removing all approvers
TIER · Nov 9, 2022 · bce1fde · bce1fde
1 parent 500b960
commit bce1fde
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 10 deletions.
diff --git a/.../java/edu/internet2/tier/shibboleth/admin/ui/security/repository/ApproversRepository.java b/.../java/edu/internet2/tier/shibboleth/admin/ui/security/repository/ApproversRepository.java
@@ -2,17 +2,22 @@
 
 import edu.internet2.tier.shibboleth.admin.ui.security.model.Approvers;
 import org.springframework.data.jpa.repository.JpaRepository;
+import org.springframework.data.jpa.repository.Modifying;
 import org.springframework.data.jpa.repository.Query;
 import org.springframework.data.repository.query.Param;
 
 import java.util.List;
 
 public interface ApproversRepository extends JpaRepository<Approvers, String> {
+    @Modifying
+    @Query(nativeQuery = true, value="DELETE FROM approvers_user_groups WHERE approver_groups_resource_id IN (:ids)")
+    void deleteGroupAssociationsForIds(@Param("ids") List<String> ids);
+
     Approvers findByResourceId(String resourceId);
 
     @Query(nativeQuery = true,
-           value = "SELECT resource_id FROM approvers WHERE resource_id IN (SELECT approvers_resource_id " +
-                   "                                                          FROM approvers_user_groups " +
-                   "                                                         WHERE approver_groups_resource_id = :resourceId)")
+           value = "SELECT approvers_list_resource_id " +
+                   "  FROM user_groups_approvers " +
+                   " WHERE user_groups_resource_id = :resourceId")
     List<String> getApproverIdsForGroup(@Param("resourceId") String resourceId);
 }
diff --git a/...ain/java/edu/internet2/tier/shibboleth/admin/ui/security/repository/GroupsRepository.java b/...ain/java/edu/internet2/tier/shibboleth/admin/ui/security/repository/GroupsRepository.java
@@ -10,12 +10,8 @@
 
 public interface GroupsRepository extends JpaRepository<Group, String> {
     @Modifying
-    @Query(nativeQuery = true,
-           value = "DELETE user_groups_approvers " +
-                   " WHERE approvers_list_resource_id IN (SELECT approvers_list_resource_id " +
-                   "                                        FROM user_group_approvers " +
-                   "                                       WHERE user_groups_resource_id = :resourceId)")
-    void clearApproversForGroup(@Param("resourceId") String resourceId);
+    @Query(nativeQuery = true, value = "DELETE FROM user_groups_approvers WHERE approvers_list_resource_id IN (:approverIds)")
+    void clearApproversByApproverIds(@Param("approverIds") List<String> approverIds);
 
     void deleteByResourceId(String resourceId);
 

diff --git a/...c/main/java/edu/internet2/tier/shibboleth/admin/ui/security/service/GroupServiceImpl.java b/...c/main/java/edu/internet2/tier/shibboleth/admin/ui/security/service/GroupServiceImpl.java
@@ -129,8 +129,10 @@ private void manageApproversList(Group group) {
         AtomicInteger approversCount = new AtomicInteger();
         group.getApproversList().forEach(a -> approversCount.addAndGet(a.getApproverGroupIds().size()));
         if (approversCount.intValue() == 0) {
+            // Need to manually manage the join tables
             List<String> ids = approversRepository.getApproverIdsForGroup(group.getResourceId());
-            groupRepository.clearApproversForGroup(group.getResourceId());
+            groupRepository.clearApproversByApproverIds(ids);
+            approversRepository.deleteGroupAssociationsForIds(ids);
             approversRepository.deleteAllById(ids);
             group.setApproversList(new ArrayList<>());
             return;