SHIBUI-2380

Fixed NPE issue when viewing version history of entity descriptor
TIER · Oct 17, 2022 · c654f28 · c654f28
1 parent cd75731
commit c654f28
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/...n/java/edu/internet2/tier/shibboleth/admin/ui/service/JPAEntityDescriptorServiceImpl.java b/...n/java/edu/internet2/tier/shibboleth/admin/ui/service/JPAEntityDescriptorServiceImpl.java
@@ -517,7 +517,7 @@ private void setupSecurityRepresentationFromEntityDescriptor(EntityDescriptor ed
                 keyDescriptorRep.setElementType(keyInfoType);
                 if (keyInfoType != KeyDescriptorRepresentation.ElementType.unsupported) {
                     List<XMLObject> children = keyInfo.getOrderedChildren().stream().filter(xmlObj -> {
-                        boolean xmlWeDoNotWant = xmlObj instanceof KeyName || xmlObj instanceof KeyValue;
+                        boolean xmlWeDoNotWant = xmlObj instanceof KeyName || xmlObj instanceof KeyValue || xmlObj == null;
                         return !xmlWeDoNotWant;
                     }).collect(Collectors.toList());
                     XMLObject obj = children.get(0);
@@ -533,7 +533,7 @@ private void setupSecurityRepresentationFromEntityDescriptor(EntityDescriptor ed
 
     private KeyDescriptorRepresentation.ElementType determineKeyInfoType(KeyInfo keyInfo) {
         List<XMLObject> children = keyInfo.getOrderedChildren().stream().filter(xmlObj -> {
-            boolean xmlWeDoNotWant = xmlObj instanceof KeyName || xmlObj instanceof KeyValue;
+            boolean xmlWeDoNotWant = xmlObj instanceof KeyName || xmlObj instanceof KeyValue || xmlObj == null;
             return !xmlWeDoNotWant;
         }).collect(Collectors.toList());
         if (children.size() < 1) {