Skip to content

Commit

Permalink
SHIBUI-574 Fixed routing issues
Browse files Browse the repository at this point in the history
  • Loading branch information
rmathis committed Jul 9, 2018
1 parent 9ce246f commit f223af8
Show file tree
Hide file tree
Showing 9 changed files with 49 additions and 36 deletions.
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { Component } from '@angular/core';

@Component({
// selector: 'dashboard-providers-list',
selector: 'dashboard-providers-list',
templateUrl: './dashboard-providers-list.component.html'
})

Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { Component } from '@angular/core';

@Component({
// selector: 'dashboard-resolvers-list',
selector: 'dashboard-resolvers-list',
templateUrl: './dashboard-resolvers-list.component.html'
})

Expand Down
46 changes: 24 additions & 22 deletions ui/src/app/metadata/manager/container/manager.component.html
Original file line number Diff line number Diff line change
Expand Up @@ -24,28 +24,30 @@
</li>
</ul>
<router-outlet></router-outlet>
<ul class="list-unstyled m-0">
<li *ngFor="let entity of limited$ | async; index as i" [ngClass]="{'mt-2': i > 0}" aria-label="Provider Item Accordion. Press Spacebar to open">
<entity-item
[entity]="entity"
[isOpen]="(entitiesOpen$ | async)[entity.getId()]"
(select)="edit(entity)"
(toggle)="toggleEntity(entity)"
(preview)="openPreviewDialog(entity)"
(delete)="deleteResolver(entity)">
</entity-item>
</li>
</ul>
<div class="mt-3 clearfix" *ngIf="(total$ | async) > limit">
<ngb-pagination
class="float-right"
[collectionSize]="total$ | async"
[page]="page"
[pageSize]="limit"
(pageChange)="changePage($event)"
aria-label="Pages">
</ngb-pagination>
</div>
<!--
<ul class="list-unstyled m-0">
<li *ngFor="let entity of limited$ | async; index as i" [ngClass]="{'mt-2': i > 0}" aria-label="Provider Item Accordion. Press Spacebar to open">
<entity-item
[entity]="entity"
[isOpen]="(entitiesOpen$ | async)[entity.getId()]"
(select)="edit(entity)"
(toggle)="toggleEntity(entity)"
(preview)="openPreviewDialog(entity)"
(delete)="deleteResolver(entity)">
</entity-item>
</li>
</ul>
<div class="mt-3 clearfix" *ngIf="(total$ | async) > limit">
<ngb-pagination
class="float-right"
[collectionSize]="total$ | async"
[page]="page"
[pageSize]="limit"
(pageChange)="changePage($event)"
aria-label="Pages">
</ngb-pagination>
</div>
-->
</div>
</section>
</div>
1 change: 0 additions & 1 deletion ui/src/app/metadata/manager/container/manager.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ import { RemoveDraftRequest } from '../../resolver/action/draft.action';

@Component({
selector: 'manager-page',
changeDetection: ChangeDetectionStrategy.OnPush,
templateUrl: './manager.component.html',
styleUrls: ['./manager.component.scss']
})
Expand Down
4 changes: 2 additions & 2 deletions ui/src/app/metadata/manager/manager.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ import { EffectsModule } from '@ngrx/effects';
import { ManagerComponent } from './container/manager.component';
import { EntityItemComponent } from './component/entity-item.component';
import { ProviderSearchComponent } from './component/provider-search.component';
import { DashboardResolversListComponent } from './component/dashboard-resolvers-list.component';
import { DashboardProvidersListComponent } from './component/dashboard-providers-list.component';
import { DashboardResolversListComponent } from './container/dashboard-resolvers-list.component';
import { DashboardProvidersListComponent } from './container/dashboard-providers-list.component';
import { reducers } from './reducer';
import { SearchEffects } from './effect/search.effects';
import { DeleteDialogComponent } from './component/delete-dialog.component';
Expand Down
19 changes: 19 additions & 0 deletions ui/src/app/metadata/manager/manager.routing.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
import { Routes } from '@angular/router';
import { DashboardResolversListComponent } from './container/dashboard-resolvers-list.component';
import { DashboardProvidersListComponent } from './container/dashboard-providers-list.component';
import { ManagerComponent } from './container/manager.component';

export const ManagerRoutes: Routes = [
{ path: '', redirectTo: 'manager', pathMatch: 'prefix' },
{
path: 'manager',
component: ManagerComponent,
children: [
{ path: '', redirectTo: 'resolvers', pathMatch: 'prefix' },
{ path: 'resolvers', component: DashboardResolversListComponent },
{ path: 'providers', component: DashboardProvidersListComponent },
]
}
];


11 changes: 2 additions & 9 deletions ui/src/app/metadata/metadata.routing.ts
Original file line number Diff line number Diff line change
@@ -1,24 +1,17 @@
import { NgModule } from '@angular/core';
import { Routes, RouterModule } from '@angular/router';

import { ManagerComponent } from './manager/container/manager.component';
import { DashboardResolversListComponent } from './manager/component/dashboard-resolvers-list.component';
import { DashboardProvidersListComponent } from './manager/component/dashboard-providers-list.component';
import { MetadataPageComponent } from './metadata.component';

import { ResolverRoutes } from './resolver/resolver.routing';
import { ProviderRoutes } from './provider/provider.routing';
import { ManagerRoutes } from './manager/manager.routing';

const routes: Routes = [
{
path: '',
component: MetadataPageComponent,
children: [
{ path: '', component: ManagerComponent, children: [
{ path: '', redirectTo: 'resolvers', pathMatch: 'full' },
{ path: 'resolvers', component: DashboardResolversListComponent },
{ path: 'providers', component: DashboardProvidersListComponent },
] },
...ManagerRoutes,
...ResolverRoutes,
...ProviderRoutes
],
Expand Down

0 comments on commit f223af8

Please sign in to comment.