SHIBUI-2063

NPE exception on login fix
TIER · Sep 15, 2021 · f27a026 · f27a026
1 parent 01b1412
commit f27a026
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 1 deletion.
diff --git a/pac4j-module/src/main/java/net/unicon/shibui/pac4j/BetterSAML2Profile.java b/pac4j-module/src/main/java/net/unicon/shibui/pac4j/BetterSAML2Profile.java
@@ -4,6 +4,7 @@
 import org.pac4j.saml.profile.SAML2Profile;
 
 import java.util.Collection;
+import java.util.HashSet;
 import java.util.List;
 import java.util.Set;
 
@@ -41,7 +42,8 @@ public List<String> getGroups() {
     }
 
     public Set<String> getRoles() {
-        return (Set<String>) getAttribute(profileMapping.getRoles());
+        Set<String> result = (Set<String>) getAttribute(profileMapping.getRoles());
+        return result == null ? new HashSet<>() : result;
     }
 
     @Override

diff --git a/testbed/authentication/reverse-proxy/.gitkeep b/testbed/authentication/reverse-proxy/.gitkeep
diff --git a/testbed/authentication/reverse-proxy/certs/.gitkeep b/testbed/authentication/reverse-proxy/certs/.gitkeep