SHIBUI-2380

Incremental commit:
TIER · Sep 20, 2022 · fcef776 · fcef776
1 parent 7afc474
commit fcef776
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 3 deletions.
diff --git a/...n/java/edu/internet2/tier/shibboleth/admin/ui/service/JPAEntityDescriptorServiceImpl.java b/...n/java/edu/internet2/tier/shibboleth/admin/ui/service/JPAEntityDescriptorServiceImpl.java
@@ -85,6 +85,7 @@ public class JPAEntityDescriptorServiceImpl implements EntityDescriptorService {
     private EntityDescriptor buildDescriptorFromRepresentation(final EntityDescriptor ed, final EntityDescriptorRepresentation representation) {
         ed.setEntityID(representation.getEntityId());
         ed.setIdOfOwner(representation.getIdOfOwner());
+        ed.setProtocol(representation.getProtocol()); // SAML vs OIDC
 
         setupSPSSODescriptor(ed, representation);
         ed.setServiceProviderName(representation.getServiceProviderName());

diff --git a/...c/main/java/edu/internet2/tier/shibboleth/admin/util/EntityDescriptorConversionUtils.java b/...c/main/java/edu/internet2/tier/shibboleth/admin/util/EntityDescriptorConversionUtils.java
@@ -1,14 +1,16 @@
 package edu.internet2.tier.shibboleth.admin.util;
 
 import static edu.internet2.tier.shibboleth.admin.util.EntityDescriptorConversionUtils.getEntityAttributes;
-import static edu.internet2.tier.shibboleth.admin.util.EntityDescriptorConversionUtils.getOptionalEntityAttributes;
 import static edu.internet2.tier.shibboleth.admin.util.EntityDescriptorConversionUtils.getSPSSODescriptorFromEntityDescriptor;
 
 import java.util.Arrays;
 import java.util.Collections;
 import java.util.Optional;
 import java.util.stream.Collectors;
 
+import edu.internet2.tier.shibboleth.admin.ui.domain.EntityDescriptorProtocol;
+import edu.internet2.tier.shibboleth.admin.ui.domain.frontend.ServiceProviderSsoDescriptorRepresentation;
+import lombok.NonNull;
 import org.opensaml.xmlsec.signature.KeyInfo;
 import org.opensaml.xmlsec.signature.X509Certificate;
 import org.opensaml.xmlsec.signature.X509Data;
@@ -280,7 +282,7 @@ public static void setupSecurity(EntityDescriptor ed, EntityDescriptorRepresenta
     }
 
     public static void setupSPSSODescriptor(EntityDescriptor ed, EntityDescriptorRepresentation representation) {
-        if (representation.getServiceProviderSsoDescriptor() != null) {
+        if (representation.getServiceProviderSsoDescriptor() != null || representation.getProtocol() == EntityDescriptorProtocol.OIDC) {
             SPSSODescriptor spssoDescriptor = getSPSSODescriptorFromEntityDescriptor(ed);
 
             spssoDescriptor.setSupportedProtocols(Collections.EMPTY_LIST);
@@ -300,11 +302,21 @@ public static void setupSPSSODescriptor(EntityDescriptor ed, EntityDescriptorRep
                     spssoDescriptor.getNameIDFormats().add(nameIDFormat);
                 }
             }
+
+            if (representation.getProtocol() == EntityDescriptorProtocol.OIDC) {
+                spssoDescriptor.setExtensions(buildOidcExtensionsFromRepresentation(representation.getServiceProviderSsoDescriptor(false)));
+            }
         } else {
             ed.setRoleDescriptors(null);
         }
     }
-
+
+    private static Extensions buildOidcExtensionsFromRepresentation(@NonNull ServiceProviderSsoDescriptorRepresentation representation) {
+        Extensions result = new Extensions();
+
+        return result;
+    }
+
     public static void setupUIInfo(EntityDescriptor ed, EntityDescriptorRepresentation representation) {
         if (representation.getMdui() != null) {
             // TODO: check if we need more than a naive implementation