Merged in SHIBUI-692 (pull request #147)

SHIBUI-692 - The order of merges (SHIBUI-680, SHIBUI-692, SHIBUI-693, SHIBUI-734)

Approved-by: Shibui Jenkins <shibui.jenkins@gmail.com>
Approved-by: Bill Smith <wsmith@unicon.net>

backend/src/main/groovy/edu/internet2/tier/shibboleth/admin/ui/service/JPAMetadataResolverServiceImpl.groovy

@@ -165,10 +165,12 @@ class JPAMetadataResolverServiceImpl implements MetadataResolverService {
     }
 
     void constructXmlNodeForFilter(RequiredValidUntilFilter filter, def markupBuilderDelegate) {
-        markupBuilderDelegate.MetadataFilter(
-                'xsi:type': 'RequiredValidUntil',
-                maxValidityInterval: filter.maxValidityInterval
-        )
+        if(filter.xmlShouldBeGenerated()) {
+            markupBuilderDelegate.MetadataFilter(
+                    'xsi:type': 'RequiredValidUntil',
+                    maxValidityInterval: filter.maxValidityInterval
+            )
+        }
     }
 
     void constructXmlNodeForResolver(FilesystemMetadataResolver resolver, def markupBuilderDelegate, Closure childNodes) {

backend/src/main/java/edu/internet2/tier/shibboleth/admin/ui/domain/filters/RequiredValidUntilFilter.java

@@ -19,4 +19,8 @@ public RequiredValidUntilFilter() {
     }
 
     private String maxValidityInterval;
+
+    public boolean xmlShouldBeGenerated() {
+        return (maxValidityInterval != null) && (!maxValidityInterval.equals("PT0S"));
+    }
 }

backend/src/test/groovy/edu/internet2/tier/shibboleth/admin/ui/domain/filters/RequiredValidUntilFilterTests.groovy

@@ -0,0 +1,32 @@
+package edu.internet2.tier.shibboleth.admin.ui.domain.filters
+
+import spock.lang.Specification
+import spock.lang.Subject
+
+/**
+ * @author Dmitriy Kopylenko
+ */
+class RequiredValidUntilFilterTests extends Specification {
+
+    def "correct logic in xmlShouldBeGenerated() method"() {
+        given: "filter under test with maxValidityInterval property not set (null)"
+        @Subject
+        def filter = new RequiredValidUntilFilter()
+
+        expect:
+        !filter.xmlShouldBeGenerated()
+
+        when: "filter under test with maxValidityInterval property not set to PT0S"
+        filter.maxValidityInterval = 'PT0S'
+
+        then:
+        !filter.xmlShouldBeGenerated()
+
+        when: "filter under test with maxValidityInterval property not set to some other valid value"
+        filter.maxValidityInterval = 'PT30S'
+
+        then:
+        filter.xmlShouldBeGenerated()
+
+    }
+}