Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Fix review points
IvanZosimov committed Dec 20, 2022
1 parent 338d4e3 commit 11aaa65
Showing 7 changed files with 23 additions and 17 deletions.
17 changes: 17 additions & 0 deletions .github/workflows/basic-validation.yml
@@ -0,0 +1,17 @@
name: Basic validation

on:
pull_request:
paths-ignore:
- '**.md'
push:
branches:
- main
- releases/*
paths-ignore:
- '**.md'

jobs:
call-basic-validation:
name: Basic validation
uses: actions/reusable-workflows/.github/workflows/basic-validation.yml@main
2 changes: 1 addition & 1 deletion .github/workflows/check-dist.yml
@@ -12,6 +12,6 @@ on:
workflow_dispatch:

jobs:
call-check-dist: # The reusable workflow can be found here: https://github.com/actions/reusable-workflows/blob/main/.github/workflows/check-dist.yml
call-check-dist:
name: Check dist/
uses: actions/reusable-workflows/.github/workflows/check-dist.yml@main
2 changes: 1 addition & 1 deletion .github/workflows/codeql-analysis.yml
@@ -9,6 +9,6 @@ on:
- cron: '0 3 * * 0'

jobs:
call-codeQL-analysis: # The reusable workflow can be found here: https://github.com/actions/reusable-workflows/blob/main/.github/workflows/codeql-analysis.yml
call-codeQL-analysis:
name: CodeQL analysis
uses: actions/reusable-workflows/.github/workflows/codeql-analysis.yml@main
@@ -1,4 +1,4 @@
name: Main workflow
name: e2e tests

on:
pull_request:
@@ -12,10 +12,6 @@ on:
- '**.md'

jobs:
call-basic-validation: # The reusable workflow can be found here: https://github.com/actions/reusable-workflows/blob/main/.github/workflows/basic-validation.yml
name: Basic validation
uses: actions/reusable-workflows/.github/workflows/basic-validation.yml@main

test-setup-multiple-versions:
runs-on: ${{ matrix.operating-system }}
strategy:
@@ -324,4 +320,4 @@ jobs:
env:
NUGET_AUTH_TOKEN: NOTATOKEN
- name: Verify dotnet
run: __tests__/verify-dotnet.sh 3.1.201
run: __tests__/verify-dotnet.sh 3.1.201
2 changes: 1 addition & 1 deletion .github/workflows/licensed.yml
@@ -10,6 +10,6 @@ on:
workflow_dispatch:

jobs:
call-licensed: # The reusable workflow can be found here: https://github.com/actions/reusable-workflows/blob/main/.github/workflows/licensed.yml
call-licensed:
name: Licensed
uses: actions/reusable-workflows/.github/workflows/licensed.yml@main
7 changes: 0 additions & 7 deletions __tests__/verify-no-unstaged-changes.sh

This file was deleted.

2 changes: 1 addition & 1 deletion package.json
@@ -8,7 +8,7 @@
"build": "tsc && ncc build",
"format": "prettier --write **/*.ts",
"format-check": "prettier --check **/*.ts",
"lint": "",
"lint": "echo \"Fake command that does nothing. It is used in reusable workflows\"",
"prepare": "husky install",
"test": "jest --coverage --config ./jest.config.js",
"update-installers": "nwget https://dot.net/v1/dotnet-install.ps1 -O externals/install-dotnet.ps1 && nwget https://dot.net/v1/dotnet-install.sh -O externals/install-dotnet.sh"

0 comments on commit 11aaa65

Please sign in to comment.