Skip to content

Commit

Permalink
Merge pull request #375 from akv-platform/fix-error-message
Browse files Browse the repository at this point in the history
Make throwing errors in setup-dotnet more informative
  • Loading branch information
Marko Zivic authored and GitHub committed Jan 30, 2023
2 parents 3cf27f1 + 0c86525 commit c41fd15
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
4 changes: 2 additions & 2 deletions dist/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -398,9 +398,9 @@ class DotnetCoreInstaller {
ignoreReturnCode: true,
env: process.env
};
const { exitCode, stdout } = yield exec.getExecOutput(`"${scriptPath}"`, scriptArguments, getExecOutputOptions);
const { exitCode, stderr } = yield exec.getExecOutput(`"${scriptPath}"`, scriptArguments, getExecOutputOptions);
if (exitCode) {
throw new Error(`Failed to install dotnet ${exitCode}. ${stdout}`);
throw new Error(`Failed to install dotnet, exit code: ${exitCode}. ${stderr}`);
}
return this.outputDotnetVersion(dotnetVersion.value);
});
Expand Down
6 changes: 4 additions & 2 deletions src/installer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -236,13 +236,15 @@ export class DotnetCoreInstaller {
ignoreReturnCode: true,
env: process.env as {string: string}
};
const {exitCode, stdout} = await exec.getExecOutput(
const {exitCode, stderr} = await exec.getExecOutput(
`"${scriptPath}"`,
scriptArguments,
getExecOutputOptions
);
if (exitCode) {
throw new Error(`Failed to install dotnet ${exitCode}. ${stdout}`);
throw new Error(
`Failed to install dotnet, exit code: ${exitCode}. ${stderr}`
);
}

return this.outputDotnetVersion(dotnetVersion.value);
Expand Down

0 comments on commit c41fd15

Please sign in to comment.