Merge pull request #20 from duncan-brown/shib-sp-ver-fix

[DocFix] Correct environment variables for tags in build instructions
docker · May 28, 2020 · 8e568af · 8e568af
2 parents 9a84e6d + 76761a1
commit 8e568af
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/docs/shibboleth-sp-mariadb.md b/docs/shibboleth-sp-mariadb.md
@@ -74,7 +74,7 @@ export COMANAGE_REGISTRY_SHIBBOLETH_SP_BASE_IMAGE_VERSION=1
 
 ```
 pushd comanage-registry-shibboleth-sp-base
-TAG="${COMANAGE_REGISTRY_SHIBBOLETH_SP_BASE_IMAGE_VERSION}"
+TAG=${COMANAGE_REGISTRY_SHIBBOLETH_SP_VERSION}-${COMANAGE_REGISTRY_SHIBBOLETH_SP_BASE_IMAGE_VERSION}
 docker build \
     -t comanage-registry-shibboleth-sp-base:$TAG . 
 popd
@@ -85,6 +85,7 @@ to be the version of the image you are about to build:
 
 ```
 export COMANAGE_REGISTRY_SHIBBOLETH_SP_IMAGE_VERSION=1
+export COMANAGE_REGISTRY_SHIBBOLETH_SP_VERSION=3.2.1
 ```
 
 * Build an image for COmanage Registry that uses the Shibboleth SP
@@ -97,6 +98,7 @@ docker build \
     --build-arg COMANAGE_REGISTRY_VERSION=${COMANAGE_REGISTRY_VERSION} \
     --build-arg COMANAGE_REGISTRY_BASE_IMAGE_VERSION=${COMANAGE_REGISTRY_BASE_IMAGE_VERSION} \
     --build-arg COMANAGE_REGISTRY_SHIBBOLETH_SP_BASE_IMAGE_VERSION=${COMANAGE_REGISTRY_SHIBBOLETH_SP_BASE_IMAGE_VERSION} \
+    --build-arg COMANAGE_REGISTRY_SHIBBOLETH_SP_VERSION=${COMANAGE_REGISTRY_SHIBBOLETH_SP_VERSION} \
     -t comanage-registry:$TAG .
 popd
 ```