Skip to content

Logging improvements #15

Merged
2 commits merged into from Aug 18, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
21 changes: 2 additions & 19 deletions .gitignore
Expand Up @@ -9,22 +9,5 @@ bin/start.sh
bin/stop.sh
root/**
shibboleth-identity-provider.tar.gz
test.log
bin/build.sh
bin/destroy.sh
bin/install.sh
bin/rebuild.sh
bin/rerun.sh
bin/run.sh
bin/start.sh
bin/stop.sh
bin/test.sh
bin/build.sh
bin/destroy.sh
bin/install.sh
bin/rebuild.sh
bin/rerun.sh
bin/run.sh
bin/start.sh
bin/stop.sh
bin/test.sh
logs/tomcat/**
logs/shibboleth_idp/**
6 changes: 5 additions & 1 deletion Dockerfile
Expand Up @@ -10,7 +10,11 @@ RUN chown -R root:root /opt/shibboleth/shibboleth-identity-provider-$version &&
rm -rf /usr/local/tomcat/webapps/* && \
ANT_OPTS="-Didp.target.dir=/opt/shibboleth/current" /opt/shibboleth/current/bin/build.sh && \
ln -s /opt/shibboleth/current /opt/shibboleth-idp && \
ln -s /opt/shibboleth-idp/war/idp.war $CATALINA_HOME/webapps/ROOT.war
ln -s /opt/shibboleth-idp/war/idp.war $CATALINA_HOME/webapps/ROOT.war && \
touch /usr/local/tomcat/logs/voltest && \
touch /opt/shibboleth/shibboleth-identity-provider-$version/logs/voltest

VOLUME ["/usr/local/tomcat/logs", "/opt/shibboleth/shibboleth-identity-provider-$VERSION/logs"]

EXPOSE 8080
CMD ["catalina.sh", "run"]
4 changes: 3 additions & 1 deletion bin/ci-run.sh
Expand Up @@ -3,4 +3,6 @@
# This file will run a container in the background
source common.bash .

docker run -d --name=$imagename -p 8080:8080 $maintainer/$imagename
docker run -d --name=$imagename -v $PWD/logs/tomcat:/usr/local/tomcat/logs:rw \
-v $PWD/logs/shibboleth_idp:/opt/shibboleth/shibboleth-identity-provider-$version/logs:rw \
-p 8080:8080 $maintainer/$imagename
2 changes: 2 additions & 0 deletions bin/ci-stop.sh
Expand Up @@ -3,6 +3,8 @@
# This file will run a container in the background
source common.bash .

rm logs/tomcat/*
rm logs/shibboleth_idp/*
echo "Cleaning up Docker image($maintainer/$imagename)"
docker stop $imagename >> /dev/null
docker rm $imagename
Expand Down
Empty file added logs/shibboleth_idp/.gitkeep
Empty file.
Empty file added logs/tomcat/.gitkeep
Empty file.
8 changes: 8 additions & 0 deletions tests/running.bats
Expand Up @@ -24,3 +24,11 @@ load ../common
[ "$status" -eq 0 ]
[ ${output} == *"200"* ]
}

@test "Tomcat log directory log volume" {
find logs/tomcat/catalina.*.log
}

@test "Shibboleth log directory log volume" {
find logs/shibboleth_idp/idp-process.log
}