Skip to content

Commit

Permalink
Add "see more" link to GHE-not-supported warning (#609)
Browse files Browse the repository at this point in the history
* Add "see more" link to GHE-not-supported warning

I lived for several months thinking that support for caching action on GHE is just a matter of time, because it's such an important thing to have. Only today, I discovered that originally it was not planned at all. And that people already created some workarounds. So I hope that linking the issue from the warning message will save other people from what happened to me :-)

* Update new GHE-not-supported message in tests

* Update generated dist files
  • Loading branch information
Vít Stanislav authored and GitHub committed Jul 20, 2021
1 parent 5807af2 commit 2ebdcff
Show file tree
Hide file tree
Showing 6 changed files with 405 additions and 401 deletions.
2 changes: 1 addition & 1 deletion __tests__/restore.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ test("restore on GHES should no-op", async () => {
expect(setCacheHitOutputMock).toHaveBeenCalledTimes(1);
expect(setCacheHitOutputMock).toHaveBeenCalledWith(false);
expect(logWarningMock).toHaveBeenCalledWith(
"Cache action is not supported on GHES"
"Cache action is not supported on GHES. See https://github.com/actions/cache/issues/505 for more details"
);
});

Expand Down
2 changes: 1 addition & 1 deletion __tests__/save.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ test("save on GHES should no-op", async () => {

expect(saveCacheMock).toHaveBeenCalledTimes(0);
expect(logWarningMock).toHaveBeenCalledWith(
"Cache action is not supported on GHES"
"Cache action is not supported on GHES. See https://github.com/actions/cache/issues/505 for more details"
);
});

Expand Down
Loading

0 comments on commit 2ebdcff

Please sign in to comment.