Skip to content

Commit

Permalink
Use existing check-dist implementation (#618)
Browse files Browse the repository at this point in the history
  • Loading branch information
Brian Cristante authored and GitHub committed Aug 9, 2021
1 parent c9db520 commit 6bbe742
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 17 deletions.
14 changes: 8 additions & 6 deletions .github/workflows/check-dist.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,16 @@ jobs:
- name: Install dependencies
run: npm ci

- name: Move the committed index.js file
run: mv dist/ /tmp/

- name: Rebuild the index.js file
- name: Rebuild the dist/ directory
run: npm run build

- name: Compare the expected and actual index.js files
run: git diff --ignore-all-space dist/ /tmp/dist
- name: Compare the expected and actual dist/ directories
run: |
if [ "$(git diff --ignore-space-at-eol dist/ | wc -l)" -gt "0" ]; then
echo "Detected uncommitted changes after build. See status below:"
git diff
exit 1
fi
id: diff

# If index.js was different than expected, upload the expected version as an artifact
Expand Down
11 changes: 0 additions & 11 deletions .github/workflows/workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,17 +47,6 @@ jobs:
run: npm run lint
- name: Build & Test
run: npm run test
- name: Ensure dist/ folder is up-to-date
if: ${{ runner.os == 'Linux' }}
shell: bash
run: |
npm run build
if [ "$(git diff --ignore-space-at-eol | wc -l)" -gt "0" ]; then
echo "Detected uncommitted changes after build. See status below:"
git diff
exit 1
fi

# End to end save and restore
test-save:
Expand Down

0 comments on commit 6bbe742

Please sign in to comment.