Format cache size and display on info (#85)

internet2 · Nov 13, 2019 · bb828da · bb828da
1 parent 7e7aef2
commit bb828da
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/__tests__/restore.test.ts b/__tests__/restore.test.ts
@@ -319,7 +319,7 @@ test("restore with a pull request event and cache found", async () => {
     const setCacheStateMock = jest.spyOn(actionUtils, "setCacheState");
     const downloadCacheMock = jest.spyOn(cacheHttpClient, "downloadCache");
 
-    const fileSize = 142;
+    const fileSize = 62915000;
     const getArchiveFileSizeMock = jest
         .spyOn(actionUtils, "getArchiveFileSize")
         .mockReturnValue(fileSize);
@@ -336,6 +336,7 @@ test("restore with a pull request event and cache found", async () => {
     expect(createTempDirectoryMock).toHaveBeenCalledTimes(1);
     expect(downloadCacheMock).toHaveBeenCalledWith(cacheEntry, archivePath);
     expect(getArchiveFileSizeMock).toHaveBeenCalledWith(archivePath);
+    expect(infoMock).toHaveBeenCalledWith(`Cache Size: ~60 MB (62915000 B)`);
     expect(mkdirMock).toHaveBeenCalledWith(cachePath);
 
     const IS_WINDOWS = process.platform === "win32";
@@ -412,6 +413,7 @@ test("restore with cache found for restore key", async () => {
     expect(createTempDirectoryMock).toHaveBeenCalledTimes(1);
     expect(downloadCacheMock).toHaveBeenCalledWith(cacheEntry, archivePath);
     expect(getArchiveFileSizeMock).toHaveBeenCalledWith(archivePath);
+    expect(infoMock).toHaveBeenCalledWith(`Cache Size: ~0 MB (142 B)`);
     expect(mkdirMock).toHaveBeenCalledWith(cachePath);
 
     const IS_WINDOWS = process.platform === "win32";

diff --git a/src/restore.ts b/src/restore.ts
@@ -80,7 +80,11 @@ async function run(): Promise<void> {
             await cacheHttpClient.downloadCache(cacheEntry, archivePath);
 
             const archiveFileSize = utils.getArchiveFileSize(archivePath);
-            core.debug(`File Size: ${archiveFileSize}`);
+            core.info(
+                `Cache Size: ~${Math.round(
+                    archiveFileSize / (1024 * 1024)
+                )} MB (${archiveFileSize} B)`
+            );
 
             io.mkdirP(cachePath);
 

diff --git a/src/save.ts b/src/save.ts
@@ -57,7 +57,9 @@ async function run(): Promise<void> {
         core.debug(`File Size: ${archiveFileSize}`);
         if (archiveFileSize > fileSizeLimit) {
             core.warning(
-                `Cache size of ${archiveFileSize} bytes is over the 400MB limit, not saving cache.`
+                `Cache size of ~${Math.round(
+                    archiveFileSize / (1024 * 1024)
+                )} MB (${archiveFileSize} B) is over the 400MB limit, not saving cache.`
             );
             return;
         }