Stop warning when cache is not found (#40)

The cache not being found is a common situation so very visible warning is a little too much.
internet2 · Nov 4, 2019 · ce4a52a · ce4a52a
1 parent 57f889e
commit ce4a52a
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 7 deletions.
diff --git a/src/cacheHttpClient.ts b/src/cacheHttpClient.ts
@@ -10,7 +10,7 @@ import { ArtifactCacheEntry } from "./contracts";
 
 export async function getCacheEntry(
     keys: string[]
-): Promise<ArtifactCacheEntry> {
+): Promise<ArtifactCacheEntry | null> {
     const cacheUrl = getCacheUrl();
     const token = process.env["ACTIONS_RUNTIME_TOKEN"] || "";
     const bearerCredentialHandler = new BearerCredentialHandler(token);
@@ -28,9 +28,7 @@ export async function getCacheEntry(
         getRequestOptions()
     );
     if (response.statusCode === 204) {
-        throw new Error(
-            `Cache not found for input keys: ${JSON.stringify(keys)}.`
-        );
+        return null;
     }
     if (response.statusCode !== 200) {
         throw new Error(`Cache service responded with ${response.statusCode}`);

diff --git a/src/restore.ts b/src/restore.ts
@@ -49,14 +49,20 @@ async function run() {
         }
 
         try {
+            const cacheEntry = await cacheHttpClient.getCacheEntry(keys);
+            if (!cacheEntry) {
+                core.info(
+                    `Cache not found for input keys: ${JSON.stringify(keys)}.`
+                );
+                return;
+            }
+
             let archivePath = path.join(
                 await utils.createTempDirectory(),
                 "cache.tgz"
             );
             core.debug(`Archive Path: ${archivePath}`);
 
-            const cacheEntry = await cacheHttpClient.getCacheEntry(keys);
-
             // Store the cache result
             utils.setCacheState(cacheEntry);
 
@@ -92,7 +98,7 @@ async function run() {
             utils.setCacheHitOutput(isExactKeyMatch);
 
             core.info(
-                `Cache restored from key:${cacheEntry && cacheEntry.cacheKey}`
+                `Cache restored from key: ${cacheEntry && cacheEntry.cacheKey}`
             );
         } catch (error) {
             core.warning(error.message);