Skip to content

Commit

Permalink
Use different IDs for 1) getting the directory of yarn cache 2) the c…
Browse files Browse the repository at this point in the history
…ache itself (#178)

* Use different IDs for 1) getting the directory of yarn cache 2) the cache itself

Using the current example + https://github.com/actions/cache#skipping-steps-based-on-cache-hit,

I came to a wrong conclusion that I could skip a step
if the `cache-hit` was `true` -
the ID I used was from the wrong step -
the `get yarn cache directory` step,
instead of the `get yarn cache itself` step.

I've updated the example in hopes that it'll be clearer for others aswell!

Signed-off-by: Kipras Melnikovas <kipras@kipras.org>

* Explain which ID to use for `cache-hit` in yarn's example

Signed-off-by: Kipras Melnikovas <kipras@kipras.org>
  • Loading branch information
Kipras Melnikovas authored and GitHub committed Feb 14, 2020
1 parent 4944275 commit e8230b2
Showing 1 changed file with 7 additions and 5 deletions.
12 changes: 7 additions & 5 deletions examples.md
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ For npm, cache files are stored in `~/.npm` on Posix, or `%AppData%/npm-cache` o

### Using multiple systems and `npm config`

```yaml
```yaml
- name: Get npm cache directory
id: npm-cache
run: |
Expand All @@ -157,21 +157,23 @@ For npm, cache files are stored in `~/.npm` on Posix, or `%AppData%/npm-cache` o
The yarn cache directory will depend on your operating system and version of `yarn`. See https://yarnpkg.com/lang/en/docs/cli/cache/ for more info.

```yaml
- name: Get yarn cache
id: yarn-cache
- name: Get yarn cache directory path
id: yarn-cache-dir-path
run: echo "::set-output name=dir::$(yarn cache dir)"
- uses: actions/cache@v1
id: yarn-cache # use this to check for `cache-hit` (`steps.yarn-cache.outputs.cache-hit != 'true'`)
with:
path: ${{ steps.yarn-cache.outputs.dir }}
path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
restore-keys: |
${{ runner.os }}-yarn-
```
## PHP - Composer
```yaml
```yaml
- name: Get Composer Cache Directory
id: composer-cache
run: |
Expand Down

0 comments on commit e8230b2

Please sign in to comment.