Turning error from any to unknown

internet2 · May 4, 2022 · f2d5621 · f2d5621
1 parent cab6d27
commit f2d5621
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 12 deletions.
diff --git a/src/restore.ts b/src/restore.ts
@@ -4,6 +4,11 @@ import * as core from "@actions/core";
 import { Events, Inputs, State } from "./constants";
 import * as utils from "./utils/actionUtils";
 
+interface RestoreError {
+    name: string;
+    message: string;
+}
+
 async function run(): Promise<void> {
     try {
         if (!utils.isCacheFeatureAvailable()) {
@@ -52,16 +57,17 @@ async function run(): Promise<void> {
             utils.setCacheHitOutput(isExactKeyMatch);
 
             core.info(`Cache restored from key: ${cacheKey}`);
-        } catch (error: any) {
-            if (error.name === cache.ValidationError.name) {
+        } catch (error: unknown) {
+            const typedError = error as Error;
+            if (typedError.name === cache.ValidationError.name) {
                 throw error;
             } else {
-                utils.logWarning(error.message);
+                utils.logWarning(typedError.message);
                 utils.setCacheHitOutput(false);
             }
         }
-    } catch (error: any) {
-        core.setFailed(error.message);
+    } catch (error: unknown) {
+        core.setFailed((error as Error ).message);
     }
 }
 

diff --git a/src/save.ts b/src/save.ts
@@ -49,17 +49,18 @@ async function run(): Promise<void> {
                 uploadChunkSize: utils.getInputAsInt(Inputs.UploadChunkSize)
             });
             core.info(`Cache saved with key: ${primaryKey}`);
-        } catch (error: any) {
-            if (error.name === cache.ValidationError.name) {
+        } catch (error: unknown) {
+            const typedError = error as Error;
+            if (typedError.name === cache.ValidationError.name) {
                 throw error;
-            } else if (error.name === cache.ReserveCacheError.name) {
-                core.info(error.message);
+            } else if (typedError.name === cache.ReserveCacheError.name) {
+                core.info(typedError.message);
             } else {
-                utils.logWarning(error.message);
+                utils.logWarning(typedError.message);
             }
         }
-    } catch (error: any) {
-        utils.logWarning(error.message);
+    } catch (error: unknown) {
+        utils.logWarning((error as Error).message);
     }
 }