Update instructions and remove unnecessary #TODO comment

sbyrnes · Jan 29, 2025 · 382e15b · 382e15b
1 parent 85b12e7
commit 382e15b
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 10 deletions.
diff --git a/GetStartedWithNetworkAutomation.pdf b/GetStartedWithNetworkAutomation.pdf
diff --git a/internal-lab-setup-assets/images/README.md b/internal-lab-setup-assets/images/README.md
@@ -14,21 +14,23 @@ But... if you happen to have the Cisco XRd image from CCO, here are some notes.
 
 2. Move it into the `images/` folder in this repository on your lab VM.
 
-3. Load it into docker and tag it locally with `docker load -i xrd-control-plane-container-x64.dockerv1.tgz`
+3. You may need to extract the image with something like `tar -xvzf xrd-control-plane-container-x86.7.11.1.tgz`
 
-4. Note the image name in the output, probably something like "xrd-control-plane:7.11.1"
+4. load it into docker and tag it locally with `docker load -i xrd-control-plane-container-x64.dockerv1.tgz`
+
+5. Note the image name in the output, probably something like "xrd-control-plane:7.11.1"
   ```
   $ sudo docker load -i xrd-control-plane-container-x64.dockerv1.tgz
   826e1dd2a198: Loading layer [==================================================>]   1.32GB/1.32GB
   Loaded image: ios-xr/xrd-control-plane:7.11.1
   ```
 
-5. Update the workshop.clab.yml.j2 Jinja template at the top of this repository to use the image wherever you please. For instance, like so:
+6. Update the workshop.clab.yml.j2 Jinja template at the top of this repository to use the image wherever you please. For instance, like so:
   ```
   topology:
     kinds:
       cisco_xrd:
         image: ios-xr/xrd-control-plane:7.11.1
   ```
 
-6. You are ready to generate and load your lab!
+7. You are ready to generate and load your lab!
diff --git a/lab-1/1_netmiko_lldp_neighbors_raw.py b/lab-1/1_netmiko_lldp_neighbors_raw.py
@@ -5,7 +5,7 @@
 password = "fill me in!"  # TODO
 device_type = "fill me in!"  # TODO
 hosts = ["x.x.x.x", "y.y.y.y", "z.z.z.z"]  # TODO
-command_to_run = "show lldp neighbors detail"  # TODO
+command_to_run = "show lldp neighbors detail"
 
 for host in hosts:
     # Create a variable that represents an SSH connection to our router.

diff --git a/lab-1/2_netmiko_lldp_neighbors_textfsm.py b/lab-1/2_netmiko_lldp_neighbors_textfsm.py
@@ -7,7 +7,7 @@
 password = "fill me in!"  # TODO
 device_type = "fill me in!"  # TODO
 hosts = ["x.x.x.x", "y.y.y.y", "z.z.z.z"]  # TODO
-command_to_run = "show lldp neighbors detail"  # TODO
+command_to_run = "show lldp neighbors detail"
 
 for host in hosts:
     # Create a variable that represents an SSH connection to our router.
@@ -25,8 +25,10 @@
     print(textfsm_output)
     print("\n")  # Add extra space between our outputs for each host
 
-    print(f"### This is the TextFSM output from {host}, but JSON-formatted to be prettier: ###")
+    print(
+        f"### This is the TextFSM output from {host}, but JSON-formatted to be prettier: ###"
+    )
     print(json.dumps(textfsm_output, indent=4))  # indent for readability
     print("\n")  # Add extra space between our outputs for each host
 
-    connection.disconnect()
+    connection.disconnect()
diff --git a/lab-2/3_netmiko_textfsm_update_description_to_lldp_neighbors.py b/lab-2/3_netmiko_textfsm_update_description_to_lldp_neighbors.py
@@ -7,7 +7,7 @@
 password = "clab@123"
 device_type = "cisco_xr"
 hosts = ["172.16.x.2", "172.16.x.3", "172.16.x.4"]  # TODO
-command_to_run = "show lldp neighbors detail"  # TODO
+command_to_run = "show lldp neighbors detail"
 
 for host in hosts:
     ### Here's the old stuff! ###
@@ -58,7 +58,7 @@
         configuration = [
             f"int {my_interface}",
             f"description -> {neighbor_name}, {neighbor_interface}",
-            "commit"
+            "commit",
         ]
 
         print(f"Before:{connection.send_command(f'show run int {my_interface}')}")