CFM-511/CMF-274 Tab navigation resolves wrong ID for plugin model index links/Breadcrumb fixes

[Ioannis]

No description provided.

[arlen]

lgtm

[benno]

I'm trying to reconcile the comment to what the code actually does. There is no a priori way to extrapolate from a foreign key (eg: report_id) to a fully qualified plugin name. Reports.Report would not be a valid name, it would be something like CoreReporter.Report, though this is a bad example because (the unfinished) Report model is a Pluggable Model, and therefore part of the core code.

It seems like modelNameToQualifiedModelName is trying to find any plugin that implements a model that inflects from this primary key. ie, if I have the key ssh_key_id, then the first plugin that implements SshKeysTable is returned. This will probably work most of the time, but it's not guaranteed. (What if two plugins happen to implement the same foreign key?)

Since this is in the context of Breadcrumbs, I assume what you're trying to do here is map from (eg) MatchServerAttributes (primary key match_server_id) to MatchServers. In this example, if you have access to MatchServerAttributesTable you can examine the primary link on the table, which is CoreServer.match_server_id, which will canonically tell you the correct parent model. But maybe I'm misunderstanding what you're trying to do.

[Ioannis]

I'm trying to reconcile the comment to what the code actually does. There is no a priori way to extrapolate from a foreign key (eg: report_id) to a fully qualified plugin name. Reports.Report would not be a valid name, it would be something like CoreReporter.Report, though this is a bad example because (the unfinished) Report model is a Pluggable Model, and therefore part of the core code.

It seems like modelNameToQualifiedModelName is trying to find any plugin that implements a model that inflects from this primary key. ie, if I have the key ssh_key_id, then the first plugin that implements SshKeysTable is returned. This will probably work most of the time, but it's not guaranteed. (What if two plugins happen to implement the same foreign key?)

Since this is in the context of Breadcrumbs, I assume what you're trying to do here is map from (eg) MatchServerAttributes (primary key match_server_id) to MatchServers. In this example, if you have access to MatchServerAttributesTable you can examine the primary link on the table, which is CoreServer.match_server_id, which will canonically tell you the correct parent model. But maybe I'm misunderstanding what you're trying to do.

@benno
The original code assumed a model name would always map to a single table, but different plugins can define the same model name and map to different tables.
The updated modelNameToQualifiedModelName() removes the ambiguity by looking at the requester model’s associations to determine the correct (possibly plugin-qualified) table name. If the requester has exactly one primary link, it uses that as the canonical parent and returns it immediately.
This fixes issues surfaced by tabs and nested tabs that rely on context (rather than a single direct association), such as the People View, the Enrollment Flows View, etc

[benno]

See comment above

[Ioannis]

See comment above

@benno pull request updated