Skip to content

Conversation

@Ioannis
Copy link
Contributor

@Ioannis Ioannis commented May 5, 2026

No description provided.

Comment on lines +127 to +129
// NOTE: Attribute Collector configuration can include multiple COU attributes/values, but the
// Petition record has only a single `cou_id` column. By convention/assumption we therefore
// select the first non-empty collected `cou_id` and ignore any additional values.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should reconcile this. The current (draft) of the documentation asserts that we only collect a single Person Role in a given Enrollment Flow. This is consistent with the Petition having a single COU ID, and consistent with the current configuration of the Attribute Collector, in that, as far as I can tell, there is no way to group together collections of Person Role Attributes. In other words, if I collect two COUs and two Titles, which Title goes with which COU?

We can either (1) decide that Attribute Collector only collects one set of Person Role attributes (at least for the immediate future) or (2) decide to properly support multiple Person Roles. If we choose (1), then Attribute Collector should not allow multiple single valued attributes (COU, title, organization, sponsor, valid from, etc) to be configured. If we choose (2), then we need a way to associate attributes to Roles and we need to decide what it means for the Petition metadata.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benno Since an Enrollment Flow can have multiple steps—and we can instantiate the Attribute Collector in more than one step—we could use the Enrollment Flow Step as the grouping key for Person Role attributes. In other words, for each step where an Attribute Collector is present, we would allow one COU, one title, etc., and treat that set of attributes as a single Person Role. That would let a petition represent multiple roles (one per step) rather than forcing everything into a single COU/title set. The Petition could then expose a helper that returns an array of role-attribute groups (one per step), instead of assuming/forcing a single COU per petition.

Sign in to join this conversation on GitHub.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants