-
Notifications
You must be signed in to change notification settings - Fork 4
CFM-324_Attribute_Collector_Enroller_Plugin_store_cou_id_in_petition #399
Open
Ioannis
wants to merge
1
commit into
COmanage:develop
Choose a base branch
from
Ioannis:CFM-324_Attribute_Collector_Enroller_Plugin_store_cou_id_in_petition
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+49
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should reconcile this. The current (draft) of the documentation asserts that we only collect a single Person Role in a given Enrollment Flow. This is consistent with the Petition having a single COU ID, and consistent with the current configuration of the Attribute Collector, in that, as far as I can tell, there is no way to group together collections of Person Role Attributes. In other words, if I collect two COUs and two Titles, which Title goes with which COU?
We can either (1) decide that Attribute Collector only collects one set of Person Role attributes (at least for the immediate future) or (2) decide to properly support multiple Person Roles. If we choose (1), then Attribute Collector should not allow multiple single valued attributes (COU, title, organization, sponsor, valid from, etc) to be configured. If we choose (2), then we need a way to associate attributes to Roles and we need to decide what it means for the Petition metadata.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@benno Since an Enrollment Flow can have multiple steps—and we can instantiate the Attribute Collector in more than one step—we could use the Enrollment Flow Step as the grouping key for Person Role attributes. In other words, for each step where an Attribute Collector is present, we would allow one COU, one title, etc., and treat that set of attributes as a single Person Role. That would let a petition represent multiple roles (one per step) rather than forcing everything into a single COU/title set. The
Petitioncould then expose a helper that returns an array of role-attribute groups (one per step), instead of assuming/forcing a single COU per petition.