CFM-532_Fix_undefined_coId_in_PagesController_redirects_deliver-show_causing_500s #427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ioannis
force-pushed
the
CFM-532_Fix_undefined_coId_in_PagesController_redirects_deliver-show_causing_500s
branch
from
2e9e33e to
5a8790c
Compare
satkinson
reviewed
Sep 3, 2026
Contributor
satkinson
left a comment
satkinson
left a comment
There was a problem hiding this comment.
Looks fine, but do you really need lines 179/180 if you're removing coId (capital I)?
arlen
approved these changes
Sep 3, 2026
Contributor
arlen
left a comment
arlen
left a comment
There was a problem hiding this comment.
Looks good. Note Shayna's comment - lines 179-180 in PagesController aren't needed.
…ent 500s and ensure redirect to /{coId}/pages/error-landing
Ioannis
force-pushed
the
CFM-532_Fix_undefined_coId_in_PagesController_redirects_deliver-show_causing_500s
branch
from
5a8790c to
a4cfc58
Compare
Contributor
Author
@satkinson thank you for catching this. Removed |
satkinson
approved these changes
Sep 3, 2026
Ioannis
deleted the
CFM-532_Fix_undefined_coId_in_PagesController_redirects_deliver-show_causing_500s
branch
Sign in
to join this conversation on GitHub.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.