CFM-532_Fix_undefined_coId_in_PagesController_redirects_deliver-show_causing_500s

app/config/routes.php

@@ -198,7 +198,7 @@ function (RouteBuilder $builder) {
     );
 
     /**
-     * Registry allows URLs of the form /coid/name to render as a Mostly Static Page.
+     * Registry allows URLs of the form /coid/pages/name to render as a Mostly Static Page.
      * 
      * Note this will effectively route any URL of the form /registry/x, where x consists of
      * digits, to the Pages controller. We need to filter on digits, or we'll end up taking

app/src/Controller/PagesController.php

@@ -63,7 +63,7 @@ public function deliver(string $coid, string $name) {
         // We use PagesController rather than MostlyStaticResourcesController to avoid complexities
         // with PrimaryLink lookups. We render here rather than redirecting into the MSRController to
         // reduce URL bar thrashing.
-        
+
         // MSRs are only enabled if file uploads are enabled
         $CoSettings = TableRegistry::getTableLocator()->get("CoSettings");
 
@@ -86,7 +86,7 @@ public function deliver(string $coid, string $name) {
         if(empty($msr)) {
             $this->Flash->error(__d('error', 'notfound', $name));
 
-            return $this->redirect(StringUtilities::pagesUrl($coId, "error-landing"));
+            return $this->redirect(StringUtilities::pagesUrl($coid, "error-landing"));
         }
 
         $fileContent = stream_get_contents($msr->file_content);
@@ -194,7 +194,7 @@ public function show(string $coid, string $name) {
             } else {
                 $this->Flash->error(__d('error', 'notfound', $name));
 
-                return $this->redirect(StringUtilities::pagesUrl($coId, "error-landing"));
+                return $this->redirect(StringUtilities::pagesUrl($coid, "error-landing"));
             }
         }