Addition of Person Overview/Canvas (CFM-205) #62
Changes from all commits
0fa5826
49d95a1
8edb26b
1643eb0
ddd4fc9
dead5ff
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,6 +27,9 @@ | |
msgid "activate" | ||
msgstr "Activate" | ||
|
||
msgid "add" | ||
msgstr "Add" | ||
|
||
msgid "add.a" | ||
msgstr "Add a New {0}" | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -46,7 +46,7 @@ trait PrimaryLinkTrait { | |
private $unkeyedActions = ['add', 'index']; | ||
|
||
// Actions where the primary link can be obtained by looking up the record ID | ||
private $lookupActions = ['delete', 'edit', 'view']; | ||
private $lookupActions = ['delete', 'edit', 'canvas', 'view']; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Didn't we specifically remove the I realize this will complicate the view file, below, but we can handle that pretty generically by eg allowing the controller to not use the standard view. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. At the moment, we kind of need both because of the way the tabs work under the overview. Edit = "properties" tab. There's a lot to be done to move to a complete ajax model, and I'd like this stuff to work in the meantime. There are things to like about the current approach, and we should do some A/B comparisons before we fully commit. (I'm going to work up some miro boards as well.) |
||
|
||
// Where to redirect on add or edit, can be 'self', 'index', or 'primaryLink' | ||
private $redirectGoal = 'index'; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, but is adding this comment necessary for this commit? (Same below.) We could open a new JIRA for improving error rendering.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No - it's not necessary - I just didn't want to forget about it. I'll add a jira and remove these.