Add type parameter for Accept/Reject-all validators

InCommon · Oct 3, 2017 · 23ffd04 · 23ffd04
1 parent b16ab8e
commit 23ffd04
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 7 deletions.
diff --git a/src/main/java/uk/org/iay/incommon/mda/validate/AcceptAllValidator.java b/src/main/java/uk/org/iay/incommon/mda/validate/AcceptAllValidator.java
@@ -24,11 +24,13 @@
  * A {@link Validator} which accepts any value, returning
  * {@link net.shibboleth.metadata.validate.Validator.Action#DONE}
  * to terminate any validator sequence.
+ *
+ * @param <V> type of the object to be validated
  */
-public class AcceptAllValidator extends BaseValidator implements Validator<Object> {
+public class AcceptAllValidator<V> extends BaseValidator implements Validator<V> {
 
     @Override
-    public Action validate(@Nonnull final Object e, @Nonnull final Item<?> item, @Nonnull final String stageId) {
+    public Action validate(@Nonnull final V e, @Nonnull final Item<?> item, @Nonnull final String stageId) {
         return Action.DONE;
     }
 

diff --git a/src/main/java/uk/org/iay/incommon/mda/validate/RejectAllValidator.java b/src/main/java/uk/org/iay/incommon/mda/validate/RejectAllValidator.java
@@ -29,8 +29,10 @@
  *
  * An error status is added using the value of the given property as a format string.
  * The message defaults to a simple rejection message including the object's string value.
+ *
+ * @param <V> type of the object to be validated
  */
-public class RejectAllValidator extends BaseValidator implements Validator<Object> {
+public class RejectAllValidator<V> extends BaseValidator implements Validator<V> {
 
     /**
      * Message format string.
@@ -66,7 +68,7 @@ public void setMessage(@Nonnull final String newMessage) {
     }
 
     @Override
-    public Action validate(@Nonnull final Object e, @Nonnull final Item<?> item, @Nonnull final String stageId) {
+    public Action validate(@Nonnull final V e, @Nonnull final Item<?> item, @Nonnull final String stageId) {
         final String mess = String.format(message, e);
         addError(mess, item, stageId);
         return Action.DONE;

diff --git a/src/test/java/uk/org/iay/incommon/mda/validate/AcceptAllValidatorTest.java b/src/test/java/uk/org/iay/incommon/mda/validate/AcceptAllValidatorTest.java
@@ -16,7 +16,7 @@ public class AcceptAllValidatorTest {
 
     @Test
     public void validate() throws Exception {
-        final AcceptAllValidator v = new AcceptAllValidator();
+        final AcceptAllValidator<String> v = new AcceptAllValidator<>();
         v.setId("comp");
         v.initialize();
 

diff --git a/src/test/java/uk/org/iay/incommon/mda/validate/RejectAllValidatorTest.java b/src/test/java/uk/org/iay/incommon/mda/validate/RejectAllValidatorTest.java
@@ -16,7 +16,7 @@ public class RejectAllValidatorTest {
 
     @Test
     public void validate() throws Exception {
-        final RejectAllValidator v = new RejectAllValidator();
+        final RejectAllValidator<String> v = new RejectAllValidator<>();
         v.setId("comp");
         v.initialize();
 
@@ -34,7 +34,7 @@ public void validate() throws Exception {
 
     @Test
     public void validateWithMessage() throws Exception {
-        final RejectAllValidator v = new RejectAllValidator();
+        final RejectAllValidator<Double> v = new RejectAllValidator<>();
         v.setId("comp");
         v.setMessage("decimal %.2f");
         v.initialize();