Skip to content

Resolve duplicate definition of edugain.dir #18

Open
iay opened this issue Feb 11, 2022 · 0 comments
Open

Resolve duplicate definition of edugain.dir #18

iay opened this issue Feb 11, 2022 · 0 comments

Comments

@iay
Copy link
Contributor

iay commented Feb 11, 2022

While reviewing build.xml for the upstream (UKf) deployment, I notice that this one differs in a way I'm sure wasn't intended. We should probably resolve this prior to the next merge, whenever that comes up. The good news is that the change here was related to separating the download and processing phases for the eduGAIN aggregate, which I am considering doing in the UKf tooling as well for slightly different reasons: so, it may be possible to use that version instead.

The clash is that edugain.dir is defined twice in build.xml:

Line 253:

    <property name="edugain.dir" value="${shared.ws.dir}/${git.repo.project.data}/edugain"/>

Line 265:

    <property name="edugain.dir" value="${mdx.dir}/int_edugain"/>

The way ant handles property definitions, the second of these (which turns out to be the one added in this tooling relative to the UKf version) is always ignored. That probably means that in practice, it can just be removed, but we need to validate that closely during any future merge.

Sign in to join this conversation on GitHub.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant