[SHIBUI-1226]

implemented update for ACSs
TIER · Feb 13, 2019 · 0d115f9 · 0d115f9
1 parent a475f35
commit 0d115f9
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/...n/java/edu/internet2/tier/shibboleth/admin/ui/service/JPAEntityDescriptorServiceImpl.java b/...n/java/edu/internet2/tier/shibboleth/admin/ui/service/JPAEntityDescriptorServiceImpl.java
@@ -269,6 +269,8 @@ private EntityDescriptor buildDescriptorFromRepresentation(final EntityDescripto
 
         // setup ACSs
         if (representation.getAssertionConsumerServices() != null && representation.getAssertionConsumerServices().size() > 0) {
+            // TODO: review if we need more than a naive implementation
+            getOptionalSPSSODescriptorFromEntityDescriptor(ed).ifPresent(spssoDescriptor -> spssoDescriptor.getAssertionConsumerServices().clear());
             for (AssertionConsumerServiceRepresentation acsRepresentation : representation.getAssertionConsumerServices()) {
                 AssertionConsumerService assertionConsumerService = openSamlObjects.buildDefaultInstanceOfType(AssertionConsumerService.class);
                 getSPSSODescriptorFromEntityDescriptor(ed).getAssertionConsumerServices().add(assertionConsumerService);
@@ -279,7 +281,7 @@ private EntityDescriptor buildDescriptorFromRepresentation(final EntityDescripto
                 assertionConsumerService.setLocation(acsRepresentation.getLocationUrl());
             }
         } else {
-            // TODO: implement
+            getOptionalSPSSODescriptorFromEntityDescriptor(ed).ifPresent(spssoDescriptor -> spssoDescriptor.getAssertionConsumerServices().clear());
         }
 
         // setup logout